Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add TestSequenceDiagram annotation #108

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

mkollenstart
Copy link
Contributor

What this PR changes/adds

This PR adds the TestSequenceDiagram annotation, that allows to input a string that contains a sequence diagram in the form of MermaidJS.

In the examples around the tests, I've omitted the sequenceDiagram part, since that can be added to all strings when parsing these with an annotation processor.

These sequence diagrams can be injected into documentation via an annotation processor to provide a clear overview of all tests and the expected flows from the TCK and CUT. Also for CUT developers having the sequence diagrams inline with the tests will help in debugging issues.

Copy link
Contributor

@jimmarino jimmarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, can you just change the license header on the annotation?

@@ -0,0 +1,41 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to. change this to TNO

@jimmarino jimmarino self-requested a review November 19, 2024 14:53
Copy link
Contributor

@jimmarino jimmarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment

@jimmarino jimmarino added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 19, 2024
@jimmarino
Copy link
Contributor

@mkollenstart Just some checkstyle cleanup needed.

@jimmarino jimmarino merged commit 7246ff0 into eclipse-dataspacetck:main Nov 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants