Throughput example fixes #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reicheratwork
force-pushed
the
throughput-example-fixes
branch
from
a7dfd29 to
b317905
Compare
eboasson
reviewed
May 12, 2023
There was a problem hiding this comment.
The transfer rate seems off ...
=== [Subscriber] 1050151917.000 Payload size: 8192 | Total received: 533591 samples, 4371177472 bytes | Out of order: 0 samples Transfer rate: 0.00 samples/s, 0.00 Mbit/s
It has to do with computing deltaTime (it is off by a factor of 10⁹) but I don't know the elegant solution in C++.
Otherwise I am fine with it. I can't in all honesty say "looks good to me" but I just find these "throughput" and "roundtrip" examples horrible on two counts and neither is your doing:
- They are in a sense abusing DDS and not showing anything interesting, and one runs the risk of people using it to actually do benchmarking ...
- The code has become so convoluted over the years with different options that is also not a straightforward example anymore
(Rant over 🙂)
I don't see lost samples and the rate is inline with expectations, so if you could have another look at the rate calculation, that'd be great.
Fixed the output formatting of the throughput example programs to match that of the CycloneDDS-C throughput examples Signed-off-by: Martijn Reicher <[email protected]>
Removed output dots Signed-off-by: Martijn Reicher <[email protected]>
Set batched writes on throughput example programs Signed-off-by: Martijn Reicher <[email protected]>
Fixed default parameters on throughput example programs to match those on CycloneDDS-C Signed-off-by: Martijn Reicher <[email protected]>
Fixed QoS on throughput example programs Signed-off-by: Martijn Reicher <[email protected]>
Windows does not like converting from size_t to unsigned long, so made that conversion explicit Signed-off-by: Martijn Reicher <[email protected]>
Signed-off-by: Erik Boasson <[email protected]>
Signed-off-by: Erik Boasson <[email protected]>
eboasson
force-pushed
the
throughput-example-fixes
branch
from
69b969c to
e6a4405
Compare
vecenyang
added a commit
to vecenyang/cyclonedds-cxx
that referenced
this pull request
Jun 14, 2023
Throughput example fixes (eclipse-cyclonedds#404)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the C++ throughput example program to be more in line with the expected output from the same example in CycloneDDS-C.