Improve peak matching in Target Transfer #2082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eselmeister
reviewed
Feb 11, 2025
| @@ -27,10 +27,10 @@ public class TargetTransferFilterSettings { | |||
| @JsonProperty(value = "Transfer Best Target Only", defaultValue = "false") | |||
| @JsonPropertyDescription(value = "If this value is true, only the best target will be transfered.") | |||
| private boolean useBestTargetOnly = false; | |||
| @JsonProperty(value = "Match Quality", defaultValue = "80.0") | |||
| @JsonPropertyDescription(value = "The match quality is set as the Match Factor.") | |||
| @JsonProperty(value = "Match Quality", defaultValue = "") | |||
There was a problem hiding this comment.
Why don't you set a default value?
There was a problem hiding this comment.
I want it to default to 0 (or leaving the field empty) so the match quality is taken from the source which gives correct ordering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces some edge cases while transferring peaks. Instead of choosing the first retention time overlap, I choose the nearest peak within retention overlap to improve targeting. To avoid mislabelling, I also copy the original match factor to get the target sorting right. You can still override the match factor with a fixed value. Also fixes the manual verification tick not being transferred, which also broke the peak labelling. While not perfect, this gives much better results when transferring deconvoluted MS peaks onto a FID with first derivative (CB) peak detection.