Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

&SYSNDX(1,1) reports a false positive diagnostic #212

Closed
michalbali256 opened this issue Dec 16, 2021 · 3 comments · Fixed by #233
Closed

&SYSNDX(1,1) reports a false positive diagnostic #212

michalbali256 opened this issue Dec 16, 2021 · 3 comments · Fixed by #233
Labels
released on @release-1.1.0 released

Comments

@michalbali256
Copy link
Contributor

Describe the bug
Using &SYSNDX with subscripts is valid hlasm.

To Reproduce

 MACRO
 MAC
 &SYSNDX(1,1)
 MEND 
 
 MAC

There is an error at &SYSNDX(1,1). It is valid on mainframe.

Expected behavior
No errors.

Screenshots
image

Platform

  • Editor: VS Code 1.63
  • OS: Windows
  • Plugin version: 0.15.1

Additional context
It seems like the assembler treats SYSNDX (and possibly more system variables) more like macro parameters, while we treat it internally like C type variable symbol.
@slavek-kucera
Copy link
Contributor

Based on my test, all currently supported "scalar" system variables exhibit this behavior.

@jirimosinger jirimosinger mentioned this issue Feb 25, 2022
Merged
@slavek-kucera slavek-kucera linked a pull request Mar 8, 2022 that will close this issue
fix: System variables with subscripts #233
Merged
slavek-kucera pushed a commit that referenced this issue Mar 8, 2022
@jirimosinger
fix: System variables with subscripts (#233)
f01e81b 
(fixes #212)
@github-actions
Copy link

🎉 This issue has been resolved in version 1.1.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released on @release-1.1.0 released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: System variables with subscripts jirimosinger/che-che4z-lsp-for-hlasm
2 participants
@michalbali256 @slavek-kucera