Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BRAS flagged when 2nd argument is large but still valid #177

Closed
Jakub-CZ opened this issue Sep 14, 2021 · 3 comments
Closed

BRAS flagged when 2nd argument is large but still valid #177

Jakub-CZ opened this issue Sep 14, 2021 · 3 comments
Assignees
@slavek-kucera
Labels
bug Something isn't working released on @release-0.15.0 released

Comments

@Jakub-CZ
Copy link

Describe the bug
The valid range for branch addresses in BRAS is a half of what it should be.

To Reproduce
Code a BRAS instruction so that RI2 falls between X'4000' and X'7FFF'.
The 2nd argument is falsely flagged as in error.

Expected behavior
The correct upper limit should be +65534 because the binary value represents the number of halfwords that is added
to the address of the instruction.
Similarly with the lower limit.

Screenshots
image

Platform

  • Editor: VS Code 1.60.0
  • OS: Windows
  • Plugin version: 0.14.1

Additional context
(unrelated quote)

image
@slavek-kucera
Copy link
Contributor

TEST(machine_instr_check_test, reloc_ImmS_out_of_range) should not produce any diagnostics.

@slavek-kucera slavek-kucera added the bug Something isn't working label Sep 14, 2021
@slavek-kucera slavek-kucera self-assigned this Sep 15, 2021
slavek-kucera added a commit to slavek-kucera/che-che4z-lsp-for-hlasm that referenced this issue Sep 15, 2021
@slavek-kucera
fixes eclipse-che4z#177
2ba141c
slavek-kucera added a commit that referenced this issue Sep 17, 2021
@slavek-kucera
fix: Incorrect relative immediate operand validation (fixes #177)
614c86e
@github-actions
Copy link

github-actions bot commented Nov 3, 2021

🎉 This issue has been resolved in version 0.15.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Nov 8, 2021

🎉 This issue has been resolved in version 0.15.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slavek-kucera slavek-kucera

Labels
bug Something isn't working released on @release-0.15.0 released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jakub-CZ @slavek-kucera