Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use Eclipse OpenJ9 JVM to run che-server #7297

Merged
merged 1 commit into from
Nov 15, 2017
Merged

Allow to use Eclipse OpenJ9 JVM to run che-server #7297

merged 1 commit into from
Nov 15, 2017

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Nov 10, 2017

What does this PR do?

Eclipse Che can be run on Java9 runtime. So adding Dockerfile for Eclipse JVM OpenJ9

What issues does this PR fix or reference?

#5326

Release Notes

N/A

Docs PR

N/A

Change-Id: I309e6eb1af4d0166758481bfd462c074de384ad6
Signed-off-by: Florent BENOIT [email protected]

@benoitf benoitf requested a review from riuvshin as a code owner November 10, 2017 09:56
@benoitf benoitf requested a review from a user November 10, 2017 09:56
@skabashnyuk
Copy link
Contributor

How Dockerfile.openj9 will be used?

@benoitf
Copy link
Contributor Author

benoitf commented Nov 10, 2017

ppl can use it (like centos one)

@benoitf benoitf added target/che6 kind/task Internal things, technical debt, and to-do tasks to be performed. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Nov 10, 2017
@skabashnyuk
Copy link
Contributor

skabashnyuk commented Nov 10, 2017

Imagine I'm that man who wants to use it.
Are you sure this is a right way?

+# To run it:
 +#  docker run --net=host \
 +#             --name che \
 +#             -v /var/run/docker.sock:/var/run/docker.sock \
 +#             -v /home/user/che/lib:/home/user/che/lib-copy \
 +#             -v /home/user/che/workspaces:/home/user/che/workspaces \
 +#             -v /home/user/che/storage:/home/user/che/storage \
 +#             codenvy/che-server

Onother question. Licensing.
@riuvshin afaik we adding some notes about licenses for OpenJDK. WDYT do we need to do the same here?

@benoitf
Copy link
Contributor Author

benoitf commented Nov 10, 2017

@skabashnyuk the run instruction is a duplicate of Dockerfile (I've updated to remove codenvy from image name)

about licensing AFAIK OpenJ9 is EPL 2.0 and Apache 2.0 licensed

@benoitf
Copy link
Contributor Author

benoitf commented Nov 10, 2017

@skabashnyuk also with CLI you can override name of the images, so you could use -e IMAGE_CHE="eclipse/che-server:nightly-openj9"
I may update the launch part with that flag

@skabashnyuk
Copy link
Contributor

ok. Thx for clarification.

…upporting Java9 runtime

Change-Id: I309e6eb1af4d0166758481bfd462c074de384ad6
Signed-off-by: Florent BENOIT <[email protected]>
@benoitf
Copy link
Contributor Author

benoitf commented Nov 10, 2017

@skabashnyuk I've updated build and run instructions

@benoitf benoitf self-assigned this Nov 10, 2017
@benoitf benoitf merged commit 6901e53 into che6 Nov 15, 2017
@benoitf benoitf deleted the openj9 branch November 15, 2017 06:45
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 15, 2017
@benoitf benoitf added this to the 6.0.0-M2 milestone Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants