Add JVM options for Java9 runtime #7234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It brings some required modules that are not exposed by default (javax.* classes are turned off by default) Change-Id: Ie3e63200bc5cbe7a371c00bd56333a144d68fd32 Signed-off-by: Florent BENOIT <[email protected]>
benoitf
added
the
kind/task
benoitf
added
status/code-review
skabashnyuk
approved these changes
Nov 8, 2017
There was a problem hiding this comment.
Could you please do the same here https://github.com/eclipse/che-lib/tree/master/che-tomcat8-slf4j-logback/src/assembly/bin
riuvshin
approved these changes
Nov 8, 2017
|
if I add it in in che-lib I would say that I could remove it from dockerfiles/che/entrypoint.sh |
skabashnyuk
approved these changes
Nov 8, 2017
…that are not exposed by default (javax.* classes are turned off by default) Change-Id: I Signed-off-by: Florent BENOIT <[email protected]>
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It brings some required modules that are not exposed by default (javax.* classes are turned off by default) when using Java9+ runtime
What issues does this PR fix or reference?
#7177
Release Notes
N/A
Docs PR
N/A
Change-Id: Ie3e63200bc5cbe7a371c00bd56333a144d68fd32
Signed-off-by: Florent BENOIT [email protected]