Fix DockerInternalRuntime test that is not throwing an expected checked exception #7027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… thrown by createNetwork method It is reported with new version of Mockito Replacing then the checked exception by the exception that createNetwork method can throw (which is InternalInfrastructureException) Change-Id: Icccf451ef5570494441c583495f41382246e10f1 Signed-off-by: Florent BENOIT <[email protected]>
benoitf
added
the
kind/bug
benoitf
added
status/code-review
garagatyi
approved these changes
Oct 27, 2017
|
ci-build |
akorneta
approved these changes
Oct 27, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4295/ |
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
RuntimeStartInterruptedException is a checked exception that can't be thrown by createNetwork method
It is reported with new version of Mockito
Replacing then the checked exception by the exception that createNetwork method can throw (which is InternalInfrastructureException)
note: I can change the code to what you'll expect, it's just that current code is not possible.
What issues does this PR fix or reference?
#5326
Release Notes
N/A
Docs PR
N/A
Change-Id: Icccf451ef5570494441c583495f41382246e10f1
Signed-off-by: Florent BENOIT [email protected]