Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Lucene to 7.0.1 #6971

Merged
merged 2 commits into from
Nov 2, 2017
Merged

Update Lucene to 7.0.1 #6971

merged 2 commits into from
Nov 2, 2017

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Oct 25, 2017 •
edited
Loading

before merge:

What does this PR do?

Update Lucene to version 7.0.1 which is java9 compliant

What issues does this PR fix or reference?

#5326

Release Notes

N/A

Docs PR

N/A

@benoitf benoitf added kind/task Internal things, technical debt, and to-do tasks to be performed. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. target/che6 labels Oct 25, 2017
@benoitf benoitf self-assigned this Oct 25, 2017
@benoitf benoitf requested a review from vparfonov as a code owner October 25, 2017 09:26
@benoitf benoitf requested a review from svor October 25, 2017 09:27
@vparfonov
Copy link
Contributor

ci-test

@eclipse-che eclipse-che deleted a comment from codenvy-ci Oct 25, 2017
@skabashnyuk skabashnyuk added this to the 6.0.0-M1 milestone Oct 25, 2017
@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@benoitf
Copy link
Contributor Author

benoitf commented Oct 26, 2017

@vparfonov @musienko-maxim are the tests ok ? as there are some failures

@musienko-maxim
Copy link
Contributor

musienko-maxim commented Oct 26, 2017 •
edited by vparfonov
Loading

Changes broke FindTextTest. Test has fallen because any occurrence that starts with Upper case won't be found.

@benoitf
Copy link
Contributor Author

benoitf commented Oct 26, 2017

@musienko-maxim thanks

@benoitf benoitf changed the title Update Lucene to 7.0.1 [WiP] Update Lucene to 7.0.1 Oct 31, 2017
@benoitf
Copy link
Contributor Author

benoitf commented Oct 31, 2017

ci-test

@eclipse-che eclipse-che deleted a comment from codenvy-ci Oct 31, 2017
@codenvy-ci
Copy link

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4301/

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@benoitf
Copy link
Contributor Author

benoitf commented Oct 31, 2017

@musienko-maxim could you check the new result of tests it seems I've fixed regressions

@benoitf benoitf changed the title [WiP] Update Lucene to 7.0.1 Update Lucene to 7.0.1 Oct 31, 2017
@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@musienko-maxim
Copy link
Contributor

Last iteration of the tests did not find a regression

@benoitf
Update to new Lucene 7.0.1 API
7baa22a 
Change-Id: I95ca91028114a909ec6ec0c7a7f123e8c09cab2c
Signed-off-by: Florent BENOIT <[email protected]>
@benoitf
make changes to adapt to new Lucene 7.0.0 design
69ecbbe 
Change-Id: I1053765276f25368023a499dd0e52556d94d62ce
Signed-off-by: Florent BENOIT <[email protected]>
@benoitf benoitf merged commit d999543 into che6 Nov 2, 2017
@benoitf benoitf deleted the update-lucene branch November 2, 2017 11:11
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vparfonov vparfonov vparfonov approved these changes

@svor svor svor approved these changes

Assignees

@benoitf benoitf

Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
6.0.0-M1
Development

Successfully merging this pull request may close these issues.
6 participants
@benoitf @vparfonov @codenvy-ci @musienko-maxim @svor @skabashnyuk