Use new (net.ltgt.gwt.maven) gwt-maven-plugin for compiling IDE app #6822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Zatsarynnyi <[email protected]>
vparfonov
approved these changes
Oct 19, 2017
benoitf
added
status/code-review
|
is it planned to get it on 5.x as well ? |
|
OK forget about my message it seems there are branches also in other repositories |
AndrienkoAleksandr
removed
the
status/code-review
|
Build # 4238 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/4238/ to view the results. |
This was referenced Oct 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artem Zatsarynnyi [email protected]
What does this PR do?
Removes using legacy "mojo's"
org.codehaus.mojo:gwt-maven-pluginfor GWT compilation of IDE app and adds using newnet.ltgt.gwt.maven:gwt-maven-plugininstead.Also, this PR leads to using GWT 2.8.1 which is declared in che-dependencies/che6.
Note, once we merge this PR, the same branches in che-parent and che-dependencies projects must be used for building Che from che6 branch.
Related CQs have been approved:
net.ltgt.gwt.maven:gwt-maven-plugin- https://dev.eclipse.org/ipzilla/show_bug.cgi?id=14390What issues does this PR fix or reference?
#6129
Release Notes
Docs PR