Made RuntimeDto return machine token #6732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleshchenko
added
status/code-review
benoitf
added
the
kind/task
benoitf
reviewed
Oct 13, 2017
| final WorkspaceConfigDto configDto = createConfigDto(); | ||
| final WorkspaceImpl workspace = createWorkspace(configDto); | ||
| when(wsManager.createWorkspace( | ||
| any(WorkspaceConfig.class), anyString(), anyMapOf(String.class, String.class))) |
There was a problem hiding this comment.
with Java8, anyMapOf is not required (and it is deprecated in new releases) any() is enough for type inference
There was a problem hiding this comment.
https://stackoverflow.com/questions/21783219/mockito-anymapof-nested-generics
Matchers.<Map<String, String >>any()
There was a problem hiding this comment.
BTW it's because I'm thinking of #6719
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4144/ |
skabashnyuk
previously approved these changes
Oct 13, 2017
sleshchenko
dismissed stale reviews from skabashnyuk and garagatyi
via
a83a52b
Signed-off-by: Sergii Leshchenko <[email protected]>
Signed-off-by: Sergii Leshchenko <[email protected]>
garagatyi
approved these changes
Oct 17, 2017
akorneta
approved these changes
Oct 17, 2017
skabashnyuk
approved these changes
Oct 17, 2017
benoitf
removed
the
status/code-review
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4175/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Made
RuntimeDtoreturn machine token.Also, this PR contains uncommenting and fixing tests for WorkspaceService and WorkspaceValidator.
What issues does this PR fix or reference?
#6557