Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Run/Debug PHP script" commands to the PHP and Zend stacks #3277

Merged
merged 1 commit into from
Dec 20, 2016

Conversation

kaloyan-raev
Copy link
Contributor

What does this PR do?

Adds commands to the PHP and Zend stacks for running and debugging PHP scripts, a.k.a. CLI apps:

  • "run php script" - executes the PHP script open in the current editor
  • "debug php script" - executes the PHP script open in the current editor in debug mode, i.e. it defines the required QUERY_STRING env var, so a debug session is opened to the Zend Debugger engine.

Both commands have a check if there is a file currently opened in the editor. If this is not the case, a user friendly message is printed.

What issues does this PR fix or reference?

This PR should be merge after merging the following two PRs:

Previous behavior

The user had to type these commands manually in the Terminal. While it is relatively easy for the "run php script" command, the QUERY_STRING env var is complex and requires copying the value from some doc page.

New behavior

Easier running and debugging of PHP scripts by executing Che commands.

Signed-off-by: Kaloyan Raev [email protected]

@codenvy-ci
Copy link

Can one of the admins verify this patch?

This was referenced Dec 5, 2016
@vparfonov
Copy link
Contributor

@tolusha

@kaloyan-raev kaloyan-raev merged commit 0c73b53 into master Dec 20, 2016
@kaloyan-raev kaloyan-raev deleted the php-script-commands branch December 20, 2016 14:21
@kaloyan-raev kaloyan-raev self-assigned this Dec 20, 2016
@kaloyan-raev kaloyan-raev added the kind/enhancement A feature request - must adhere to the feature request template. label Dec 20, 2016
@kaloyan-raev kaloyan-raev added this to the 5.0.0-M9 milestone Dec 20, 2016
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants