Add commands to workspace when importing project samples #2976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kaloyan Raev <[email protected]>
|
Can one of the admins verify this patch? |
|
ci-build |
benoitf
added
kind/enhancement
|
+1 |
|
Build # 917 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/917/ to view the results. |
|
@kaloyan-raev - lets fix the conflicting files. I'm asking Vitalli to take this into next sprint for merge. I'm going to ask all TLs to go through PR backlog now that we are 5.0.0 shipped. |
Conflicts: ide/che-core-ide-api/src/main/java/org/eclipse/che/ide/api/project/MutableProjectConfig.java ide/che-core-ide-app/src/main/java/org/eclipse/che/ide/projecttype/wizard/presenter/ProjectWizardPresenter.java
|
Conflicts resolved. Rebased to latest master. |
|
@vparfonov what is the state of that issue? it is planned for 5.2.0 which going tobe released in few days. |
JamesDrummond
removed
status/code-review
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
…#2976) Signed-off-by: Kaloyan Raev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If a project sample is imported from the IDE's Create Project wizard, the commands defined in the project sample will be added to the workspace. This way it will be the same like importing the project sample from the Dashboard.
What issues does this PR fix or reference?
None.
Previous behavior
Commands defined in the project sample were not added to the workspace.
New behavior
The commands are now added.
Changelog
Add commands to workspace when importing project samples
Signed-off-by: Kaloyan Raev [email protected]