Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use actions/upload-artifact@v4 in pr-check workflow #23327

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Use actions/upload-artifact@v4 in pr-check workflow #23327

merged 1 commit into from
Jan 31, 2025

Conversation

dmytro-ndp
Copy link
Contributor

@dmytro-ndp dmytro-ndp commented Jan 30, 2025

What does this PR do?

It updates "Empty Workspace test suite on minikube" workflow to begin using v4 of the artifact actions.

With this fix workflow is still failing, but because of another issue: #23328

Screenshot/screencast of this PR

What issues does this PR fix or reference?

#23326

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@dmytro-ndp dmytro-ndp requested a review from SDawley as a code owner January 30, 2025 19:50
@dmytro-ndp dmytro-ndp assigned SDawley and unassigned SDawley Jan 30, 2025
@dmytro-ndp dmytro-ndp requested a review from artaleks9 January 30, 2025 22:44
@dmytro-ndp dmytro-ndp marked this pull request as draft January 30, 2025 22:44
@dmytro-ndp dmytro-ndp marked this pull request as ready for review January 31, 2025 21:23
Copy link
Contributor

@SDawley SDawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@dmytro-ndp dmytro-ndp merged commit 99346a1 into main Jan 31, 2025
4 of 5 checks passed
@dmytro-ndp dmytro-ndp deleted the 23326 branch January 31, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants