Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test]: Changed WTO test to use kubeadmin login & fix getServerUrl #23214

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

martinszuc
Copy link

@martinszuc martinszuc commented Oct 29, 2024

What does this PR do?

In job /WTO/job/WTO-smee/job/wto-smee/ changed the login to use kube:admin based on credentials from specific Flexy-install based on build number. In this PR i edited the test code to reflect changes and to login as kubeadmin during WTO test as admin.

The server URL was incorrectly parsed (the getServerURL() expects URL in format https://devspaces.apps.ocp417......com/ ) resulting in test failing, So i fixed it by adding a case where the BASE URL contains the https://console-openshift-console.apps......com/ format which was used in this test case.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-7483

How to test this PR?

tested on https://main-jenkins-csb-crwqe.apps.ocp-c1.prod.psi.redhat.com/job/WTO/job/WTO-smee/job/wto-smee/126/

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, move all the WTO tests to the dedicated repo - it should not be part of the Eclipse Che

@martinszuc
Copy link
Author

Please, move all the WTO tests to the dedicated repo - it should not be part of the Eclipse Che

@ibuziuk Yes, we are aware, the WTO tests will be moved. These edits/contributions in this PR are small changes for test to work correctly with new changes to test's jenkins job.
WTO tests will be moved in another task which could be way more complex than these small changes. Hence i would like to include these changes here.

@ibuziuk
Copy link
Member

ibuziuk commented Oct 30, 2024

@martinszuc looks like eclipse ECA has not been signed see https://api.eclipse.org/git/eca/status/gh/eclipse-che/che/23214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants