chore: EmtpyWorkspace test path #21920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatolii Bazko <[email protected]>
tolusha
requested review from
musienko-maxim,
nickboldt,
ScrewTSW and
dmytro-ndp
as code owners
che-bot
added
target/branch
nickboldt
approved these changes
Jan 6, 2023
There was a problem hiding this comment.
Curious... the file I see in the che repo is:
https://github.com/eclipse/che/blob/main/tests/e2e/tests/devfiles/che-code/EmptyWorkspace.spec.ts (with .ts).
But this changes to refer to .js ... is that intentional?
Does the file get compiled from .ts -> .js?
|
Exactly, the extension is changed after compilation |
Yes, because there is no |
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anatolii Bazko [email protected]
What does this PR do?
fix: EmtpyWorkspace test path
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
#21836
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.