CHE-1964: add libraries from containers for building classpath #2047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine |
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
CHE-1964: add libraries from containers for building classpath
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds libraries from java containers to classpath
What issues does this PR fix or reference?
#1964
Previous Behavior
Classpath contains only external jars
New Behavior
Classpath contains only external jars, and jars from containers (for example from MAVEN_CLASSPATH_CONTAINER)
Tests written?
Yes
Please review @dkuleshov