chore(release): Set correct versions in issue template #20260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update latest to the version being tagged and add previous major version if not yet set Change-Id: Iebccac1611befbae19fe9b9c326b6ced918c818f Signed-off-by: Florent Benoit <[email protected]>
nickboldt
reviewed
Aug 5, 2021
| @@ -126,6 +171,9 @@ git commit -asm "${COMMIT_MSG}" | |||
| # now update ${BASEBRANCH} to the new snapshot version | |||
| git checkout "${BASEBRANCH}" | |||
|
|
|||
| # update template in the branch | |||
| update_issue_template "${VERSION}" "${ISSUE_TEMPLATE_FILE}" | |||
There was a problem hiding this comment.
is the issue template file in the branch ever actually used? Can you open an issue using the branch's template?
There was a problem hiding this comment.
When cutting a .z release it won't update the template BTW (no-op)
but then for .0 release it will trigger the PR to merge to main branch
There was a problem hiding this comment.
script is creating PR to update main from a branch so we need to update the branch if we want to have the template being modified in main branch through this PR
nickboldt
approved these changes
Aug 5, 2021
|
✅ E2E Happy path tests succeed 🎉 See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When doing a release, update issue template with the versions we're tagging
Screenshot/screencast of this PR
What issues does this PR fix or reference?
#20054
How to test this PR?
Extract code to a separate file and run for example
it will update
.github/ISSUE_TEMPLATE/bug_report.ymlfilePR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.
Change-Id: Iebccac1611befbae19fe9b9c326b6ced918c818f
Signed-off-by: Florent Benoit [email protected]