Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to dashboard repo movement #19618

Merged
merged 3 commits into from
Apr 16, 2021
Merged

Adapt to dashboard repo movement #19618

merged 3 commits into from
Apr 16, 2021

Conversation

sleshchenko
Copy link
Member

@sleshchenko sleshchenko commented Apr 16, 2021 •
edited
Loading

@che-bot che-bot added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Apr 16, 2021
@che-bot
Copy link
Contributor

che-bot commented Apr 16, 2021

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

dmytro-ndp
dmytro-ndp approved these changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@che-bot che-bot added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Apr 16, 2021
@sleshchenko
Copy link
Member Author

merging.
@mkuznyetsov if you have any suggestions, please let me know and I'll fix them

@sleshchenko sleshchenko merged commit c386fe8 into eclipse-che:master Apr 16, 2021
@sleshchenko sleshchenko deleted the dashboardIntoEclipseCheOrg branch April 16, 2021 12:35
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Apr 16, 2021
@che-bot
Copy link
Contributor

che-bot commented Apr 16, 2021

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@che-bot che-bot added this to the 7.30 milestone Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ndp dmytro-ndp dmytro-ndp approved these changes

@mkuznyetsov mkuznyetsov Awaiting requested review from mkuznyetsov

@nickboldt nickboldt Awaiting requested review from nickboldt

@rhopp rhopp Awaiting requested review from rhopp

@sparkoo sparkoo Awaiting requested review from sparkoo

Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
7.30
Development

Successfully merging this pull request may close these issues.
3 participants
@sleshchenko @che-bot @dmytro-ndp