Mount CA bundle into metadata broker and pass the path as argument to brokers #17630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mykola Morhun <[email protected]>
Signed-off-by: Mykola Morhun <[email protected]>
mmorhun
requested review from
metlos,
sparkoo,
skabashnyuk,
tolusha and
mshaposhnik
mmorhun
requested review from
amisevsk,
l0rd,
nickboldt and
sleshchenko
as code owners
che-bot
added
status/code-review
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
amisevsk
reviewed
Aug 13, 2020
...che/workspace/infrastructure/kubernetes/wsplugins/brokerphases/BrokerEnvironmentFactory.java
Outdated
Show resolved
Hide resolved
...che/workspace/infrastructure/kubernetes/wsplugins/brokerphases/BrokerEnvironmentFactory.java
Outdated
Show resolved
Hide resolved
mshaposhnik
reviewed
Aug 14, 2020
...eclipse/che/workspace/infrastructure/kubernetes/wsplugins/KubernetesPluginBrokerManager.java
Outdated
Show resolved
Hide resolved
mshaposhnik
reviewed
Aug 14, 2020
...g/eclipse/che/workspace/infrastructure/openshift/wsplugins/OpenshiftPluginBrokerManager.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mykola Morhun <[email protected]>
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) ℹ️ |
sleshchenko
reviewed
Aug 18, 2020
| tracer); | ||
| } | ||
|
|
||
| @Beta |
There was a problem hiding this comment.
Is it beta by purpose or just movement? I believe at this point this functionality is not beta anymore. So, please consider removing it.
...g/eclipse/che/workspace/infrastructure/openshift/wsplugins/OpenshiftPluginBrokerManager.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mykola Morhun <[email protected]>
sleshchenko
approved these changes
Aug 19, 2020
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
mshaposhnik
approved these changes
Aug 19, 2020
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Mounts trusted CA bundle into metadata plugin broker and passes
-cadirargument to both brokers if needed.Implemented only for Openshift 4 infrastructure.
Issue for other infrastructures: #17634
What issues does this PR fix or reference?
#17552
Depends on
eclipse-che/che-plugin-broker#109
eclipse-che/che-operator#409