Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRW-1124 no need to set permissions twice,... #17563

Closed
wants to merge 3 commits into from
Closed

CRW-1124 no need to set permissions twice,... #17563

wants to merge 3 commits into from

Conversation

nickboldt
Copy link
Contributor

CRW-1124 no need to set permissions twice, since the first change might make it impossible to make the second one if file is not owned by 'user' user

Change-Id: I67e3a6cde64ee1399a4421d424c76fa6ed0b3332
Signed-off-by: nickboldt [email protected]

@nickboldt nickboldt requested review from benoitf and l0rd as code owners August 4, 2020 21:15
@che-bot che-bot added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 4, 2020
@che-bot
Copy link
Contributor

che-bot commented Aug 4, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

@nickboldt nickboldt requested a review from dmytro-ndp August 28, 2020 11:53
@che-bot
Copy link
Contributor

che-bot commented Aug 28, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

@nickboldt
Copy link
Contributor Author

nickboldt commented Aug 28, 2020 •
edited
Loading

@l0rd @benoitf can I get an approval on this PR? It's been tested in BOTH CRW 2.3 / Che 7.16.x and CRW 2.4 / Che 7.18.x and works. Obvi the happy path tests are failing but I know it works :D

@dmytro-ndp
Copy link
Contributor

@nickboldt: could you, please, take a look at Che deployment error encountered during Happy path tests execution [1]:

Using embedded assembly in /home/user/eclipse-che/.
Found a custom cert. Adding it to java trust store /home/user/cacerts based on /usr/local/openjdk-11/lib/security/cacerts
Trust this certificate? [no]:  Certificate was added to keystore

[08:06:24] → ERR_TIMEOUT: Timeout set to pod ready timeout 180000
[08:06:24] Eclipse Che pod bootstrap [failed]
[08:06:24] → ERR_TIMEOUT: Timeout set to pod ready timeout 180000
[08:06:24] ✅  Post installation checklist [failed]
[08:06:24] → ERR_TIMEOUT: Timeout set to pod ready timeout 180000
 ›   Error: Error: ERR_TIMEOUT: Timeout set to pod ready timeout 180000
 ›   Installation failed, check logs in '/tmp/chectl-logs/1598616016682'

[1] #17563 (comment)

@nickboldt
Copy link
Contributor Author

[crw-ci-test]

@nickboldt
CRW-1124 no need to set permissions twice, since the first change mig…
aef4cd4 
…ht make it impossible to make the second one if file is not owned by 'user' user

Change-Id: I67e3a6cde64ee1399a4421d424c76fa6ed0b3332
Signed-off-by: nickboldt <[email protected]>

CRW-1124 just in case we need other to have write permissions, let's set it in Dockerfile (and then switch to 444 after updating cacerts file)

Change-Id: I26db795b876849e2b2e66c6ef116cee5764ff0f8
Signed-off-by: nickboldt <[email protected]>
@che-bot
Copy link
Contributor

che-bot commented Aug 28, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

@nickboldt
CRW-1124 CRW-1189 fix dir permissions for use with cacert creation, a…
4c11a31 
…nd add bonus catalina.sh startup test too (copied from downstream)

Change-Id: I3fb0e3fc6510c084ae24dd225719203fdecf4a2c
Signed-off-by: nickboldt <[email protected]>
@nickboldt
Copy link
Contributor Author

Could be permissions in the Dockerfile that don't work the same w/ Che on alpine as they do for CRW on UBI8.

testing this change:

4c11a31

@che-bot
Copy link
Contributor

che-bot commented Aug 28, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Aug 28, 2020 •
edited
Loading

@nickboldt: there was Che image build error in Happy path tests:

Step 20/21 : RUN mkdir /logs /data &&     chmod 0777 /logs /data &&     chgrp -R 0 /home/user /logs /data &&     chown -R user /home/user &&     chmod -R g+rwX /home/user &&     find /home/user -type d -exec chmod 777 {} \; &&     chmod g+w /home/user/cacerts &&     java -version && echo -n "Server startup script in: " &&     find /home/user/eclipse-che -name catalina.sh | grep -z /home/user/eclipse-che/tomcat/bin/catalina.sh
 ---> Running in 4c24166575f8
chown: invalid user: ‘user’
The command '/bin/sh -c mkdir /logs /data &&     chmod 0777 /logs /data &&     chgrp -R 0 /home/user /logs /data &&     chown -R user /home/user &&     chmod -R g+rwX /home/user &&     find /home/user -type d -exec chmod 777 {} \; &&     chmod g+w /home/user/cacerts &&     java -version && echo -n "Server startup script in: " &&     find /home/user/eclipse-che -name catalina.sh | grep -z /home/user/eclipse-che/tomcat/bin/catalina.sh' returned a non-zero code: 1
script returned exit code 1

@nickboldt
don't create user user
63c1816 
Change-Id: Ie11e5fb36a64142a613ee469d4a0adba04813309
Signed-off-by: nickboldt <[email protected]>
@che-bot
Copy link
Contributor

che-bot commented Aug 28, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

@skabashnyuk
Copy link
Contributor

@nickboldt can you update your pr and make sure tests are passing?

@nickboldt
Copy link
Contributor Author

After conversation today w/ @skabashnyuk and @tolusha ... this PR will be subsumed into #18504 (review)

@nickboldt
Copy link
Contributor Author

Fixed in issue #18339 via PR #18504

@nickboldt nickboldt closed this Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf Awaiting requested review from benoitf

@l0rd l0rd Awaiting requested review from l0rd

@dmytro-ndp dmytro-ndp Awaiting requested review from dmytro-ndp

Assignees
No one assigned
Labels
status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nickboldt @che-bot @dmytro-ndp @skabashnyuk