Read self-signed certiicate from dedicated secret #17044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith operator installer) Signed-off-by: Mykola Morhun <[email protected]>
che-bot
added
status/code-review
tolusha
reviewed
May 29, 2020
| @@ -100,7 +100,7 @@ spec: | |||
| valueFrom: | |||
| secretKeyRef: | |||
| key: ca.crt | |||
| name: {{ .Values.global.tls.secretName }} | |||
| name: {{ .Values.global.tls.selfSignedCertSecretName }} | |||
There was a problem hiding this comment.
It is not good to change the value name.
Somebody might use it
There was a problem hiding this comment.
No, I didn't change the name. This change just says: "Read ca.crt from selfSignedCertSecretName secret instead of secretName secret". Names are unchanged.
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
tolusha
approved these changes
Jun 1, 2020
AndrienkoAleksandr
approved these changes
Jun 1, 2020
che-bot
removed
the
status/code-review
mmorhun
added a commit
that referenced
this pull request
Jun 16, 2020
…ith operator installer) (#17044) Signed-off-by: Mykola Morhun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mykola Morhun [email protected]
What does this PR do?
Makes
self-signed-certificatesecret the source of Che server CA certificate. This is done to be consistent with other installers. Also such approach make autodetection of self-signed certificate usage easier.What issues does this PR fix or reference?
Issue: #16764
Should be merged together with che-incubator/chectl#734