Align JGroups labels property name and add one preventing to connect to unready pods #15282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshaposhnik
added
the
kind/bug
skabashnyuk
approved these changes
Nov 22, 2019
che-bot
added
the
status/code-review
…onnect to unready pods;
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) ℹ️ |
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) ℹ️ |
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
|
Can we backport that to 7.3.x? |
|
ci-test |
|
E2E tests of Eclipse Che Multiuser on OCP has been successful:
|
che-bot
removed
the
status/code-review
Closed
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Align JGroups labels property name with original one in
KUBE_PING(see https://github.com/jgroups-extras/jgroups-kubernetes/blob/master/src/main/java/org/jgroups/protocols/kubernetes/KUBE_PING.java#L81) to avoid possible inconsistency and add another preventing to connect to unready pods which will help to reduce number ofConnectioRefusedwarning when trying to connect to not yet fully started pod.Issue to
KUBE_PINGupstream to align their documentation: jgroups-extras/jgroups-kubernetes#79What issues does this PR fix or reference?
#15176
Release Notes
N/A
Docs PR
N/A