Add Jenkinsfile to run E2E Happy path tests against K8S #14149

dmytro-ndp · 2019-08-07T15:37:37Z

What does this PR do?

It's aimed to replace shell script to run E2E Happy path tests, which is in-build into PR check job on CRW CI, with Jenkinsfile.

Jenkins pipeline makes it much more clear at which stage the build has been failed, and it's much easier to support due to Declarative pipeline structure + Groovy script syntax.
It also allows to decrease of build time on about 3 minutes from 21-22 minutes to 18 minutes due to build of Che and start of K8S in a parallel.

An example of Jenkinsfile execution: https://codeready-workspaces-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/blue/organizations/jenkins/Single-Che-PR-check-E2E-Happy-path-tests-against-k8s-on-codenvy-slave9/detail/Single-Che-PR-check-E2E-Happy-path-tests-against-k8s-on-codenvy-slave9/12/pipeline/

What issues does this PR fix or reference?

#14068

Signed-off-by: Dmytro Nochevnov <[email protected]>

todo · 2019-08-07T15:37:41Z

switch to eclipse/che-e2e image

https://github.com/eclipse/che/blob/3c7f761079f7e7c22e70fe5c666f2cf39716c82a/e2e/jenkins/crw-ci/k8s/pr-check/Jenkinsfile#L174-L179

This comment was generated by todo based on a `TODO` comment in `3c7f761` in #14149. cc @eclipse.

che-bot · 2019-08-07T15:59:43Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
docker image: docker.io/maxura/che-server:14149

rhopp

The sh steps formatting is really weird..

rhopp · 2019-08-07T15:58:51Z

e2e/jenkins/crw-ci/k8s/pr-check/Jenkinsfile

+                        script {
+                            sh """
+  wget --no-verbose https://github.com/che-incubator/chectl/releases/latest/download/chectl-linux
+  sudo mv chectl-linux /usr/local/bin/chectl


Wouldn't it be better to put chectl executable somewhere inside workspace and put that directory on PATH?

Probably, yes, it would be better. Thanks for advice!

rhopp · 2019-08-07T15:59:49Z

e2e/jenkins/crw-ci/k8s/pr-check/Jenkinsfile

+                stage("Cleanup") {
+                    steps {
+                        script() {
+                            sh "env"


Does this serve any purpose?

no, it doesn't now.
Thanks for notice!

rhopp · 2019-08-07T16:05:34Z

e2e/jenkins/crw-ci/k8s/pr-check/Jenkinsfile

+            failFast true
+
+            parallel {
+                stage("Cleanup") {


Wouldn't it be better to do cleanup in post actions? Using

cleanWs notFailBuild: true

There could be builds aborted before, so we should insure codenvy-slave9 is ready for usage.

And cleanWs notFailBuild: true is suitable here as well. Thanks for advice.

UPDATE: cleanWs notFailBuild: true IS NOT suitable here. I have mislead that command propose.

rhopp · 2019-08-07T16:10:25Z

e2e/jenkins/crw-ci/k8s/pr-check/Jenkinsfile

+                    sh """
+  /usr/local/bin/chectl server:start \\
+   --k8spodreadytimeout=180000 \\
+   -t=${WORKSPACE}/deploy/ \\


Where did this ${WORKSPACE}/deploy/ folder came from? eclipse/che git repo is cloned into relative dir che... Shouldn't this be ${WORKSPACE}/che/deploy?

Good catch!
There is che project content in the root of workspace directory on codenvy-slave9 remained from previous builds.

rhopp · 2019-08-07T16:11:55Z

e2e/jenkins/crw-ci/k8s/pr-check/Jenkinsfile

+        PATH = "/tmp:/qa/tools/opt/apache-maven-3.5.4/bin:$PATH"
+        JENKINS_BUILD = "true"
+
+        DEVFILE_URL = "${WORKSPACE}/e2e/files/happy-path/happy-path-workspace.yaml"


Missing che directory? ${WORKSPACE}/che/e2e/files/happy-path/happy-path-workspace.yaml?

Good catch!
There is che project content in the root of workspace directory on codenvy-slave9 remained from previous builds.

rhopp · 2019-08-07T16:12:42Z

e2e/jenkins/crw-ci/k8s/pr-check/Jenkinsfile

+                script {
+                    sh """
+  /usr/local/bin/chectl workspace:start --devfile=$DEVFILE_URL
+  kubectl get configmaps --namespace=che che -o yaml


Some debugging leftovers?

It could be moved to post action steps, indeed.

rhopp · 2019-08-07T16:17:14Z

e2e/jenkins/crw-ci/k8s/pr-check/Jenkinsfile

+        always {
+            script {
+                // it's impossible to use 'when' in the global post block
+                if (currentBuild.currentResult != 'ABORTED') {


Why is this not executing on aborting the job?

Agree. Let's execute it anyway. Thanks for advice!

Signed-off-by: Dmytro Nochevnov <[email protected]>

che-bot · 2019-08-07T23:01:48Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14149

Signed-off-by: Dmytro Nochevnov <[email protected]>

dmytro-ndp · 2019-08-08T07:08:50Z

@rhopp: could you, please, review fixup to your notices?

Signed-off-by: Dmytro Nochevnov <[email protected]>

dmytro-ndp · 2019-08-08T09:24:29Z

new-ci-test

Signed-off-by: Dmytro Nochevnov <[email protected]>

rhopp · 2019-08-08T13:27:25Z

e2e/jenkins/crw-ci/k8s/pr-check/Jenkinsfile

+        stage("Create test workspace") {
+            steps {
+                script {
+                    sh "/usr/local/bin/chectl workspace:start --devfile=$DEVFILE_URL"


I think you should use ${WORKSPACE}/chectl

good catch!
I must have fixed it.

Signed-off-by: Dmytro Nochevnov <[email protected]>

che-bot · 2019-08-08T22:29:46Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-server" docker image: maxura/che-server:14149

Add Jenkinsfile to run E2E Happy path tests

3c7f761

Signed-off-by: Dmytro Nochevnov <[email protected]>

dmytro-ndp added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. team/che-qe labels Aug 7, 2019

dmytro-ndp requested a review from rhopp August 7, 2019 15:37

dmytro-ndp requested review from l0rd, musienko-maxim, nickboldt and Ohrimenko1988 as code owners August 7, 2019 15:37

rhopp requested changes Aug 7, 2019

View reviewed changes

dmytro-ndp added 3 commits August 7, 2019 20:12

Apply PR review notices

b6f4098

Signed-off-by: Dmytro Nochevnov <[email protected]>

Apply PR review notices

f7b8183

Signed-off-by: Dmytro Nochevnov <[email protected]>

Add build timeout

3282630

Signed-off-by: Dmytro Nochevnov <[email protected]>

Don't clean ws at start

60df5d6

Signed-off-by: Dmytro Nochevnov <[email protected]>

Rely on Jenkinsfile in PR source

5e1a5f1

Signed-off-by: Dmytro Nochevnov <[email protected]>

dmytro-ndp added 2 commits August 8, 2019 14:48

Fix path in Jenkinsfile

0a44fd3

Signed-off-by: Dmytro Nochevnov <[email protected]>

Clear jenkins workspace immediately at post action

86f859c

Signed-off-by: Dmytro Nochevnov <[email protected]>

rhopp reviewed Aug 8, 2019

View reviewed changes

dmytro-ndp added 2 commits August 8, 2019 16:28

Fix formatting of multiline sh command

5f0e0cd

Signed-off-by: Dmytro Nochevnov <[email protected]>

Fix chectl path

91d6826

Signed-off-by: Dmytro Nochevnov <[email protected]>

rhopp approved these changes Aug 8, 2019

View reviewed changes

eclipse-che deleted a comment from che-bot Aug 8, 2019

dmytro-ndp mentioned this pull request Aug 8, 2019

[WIP] Move to crw-ci/pr-check/k8s/Jenkinsfile #14169

Closed

dmytro-ndp added 2 commits August 9, 2019 01:12

Fix cleanup, fix arhiving artifacts

de6322d

Signed-off-by: Dmytro Nochevnov <[email protected]>

Move to crw-ci/pr-check/k8s/Jenkinsfile

30a70f5

Signed-off-by: Dmytro Nochevnov <[email protected]>

eclipse-che deleted a comment from che-bot Aug 8, 2019

dmytro-ndp merged commit e1c2b87 into master Aug 8, 2019

todo bot mentioned this pull request Aug 8, 2019

switch to eclipse/che-e2e image #14170

Closed

che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 8, 2019

dmytro-ndp deleted the che-14068 branch August 9, 2019 23:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Jenkinsfile to run E2E Happy path tests against K8S #14149

Add Jenkinsfile to run E2E Happy path tests against K8S #14149

dmytro-ndp commented Aug 7, 2019 •

edited

Loading

todo bot commented Aug 7, 2019

che-bot commented Aug 7, 2019

rhopp left a comment

rhopp Aug 7, 2019

dmytro-ndp Aug 7, 2019

rhopp Aug 7, 2019

dmytro-ndp Aug 7, 2019 •

edited

Loading

rhopp Aug 7, 2019

dmytro-ndp Aug 7, 2019

dmytro-ndp Aug 7, 2019

dmytro-ndp Aug 8, 2019

rhopp Aug 7, 2019

dmytro-ndp Aug 7, 2019 •

edited

Loading

rhopp Aug 7, 2019

dmytro-ndp Aug 7, 2019 •

edited

Loading

rhopp Aug 7, 2019

dmytro-ndp Aug 7, 2019 •

edited

Loading

rhopp Aug 7, 2019

dmytro-ndp Aug 7, 2019

che-bot commented Aug 7, 2019

dmytro-ndp commented Aug 8, 2019

dmytro-ndp commented Aug 8, 2019

rhopp Aug 8, 2019

dmytro-ndp Aug 8, 2019

che-bot commented Aug 8, 2019

Add Jenkinsfile to run E2E Happy path tests against K8S #14149

Add Jenkinsfile to run E2E Happy path tests against K8S #14149

Conversation

dmytro-ndp commented Aug 7, 2019 • edited Loading

What does this PR do?

What issues does this PR fix or reference?

todo bot commented Aug 7, 2019

switch to eclipse/che-e2e image

This comment was generated by todo based on a TODO comment in 3c7f761 in #14149. cc @eclipse.

che-bot commented Aug 7, 2019

rhopp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dmytro-ndp Aug 7, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dmytro-ndp Aug 7, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dmytro-ndp Aug 7, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dmytro-ndp Aug 7, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

che-bot commented Aug 7, 2019

dmytro-ndp commented Aug 8, 2019

dmytro-ndp commented Aug 8, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

che-bot commented Aug 8, 2019

dmytro-ndp commented Aug 7, 2019 •

edited

Loading

This comment was generated by todo based on a `TODO` comment in `3c7f761` in #14149. cc @eclipse.

dmytro-ndp Aug 7, 2019 •

edited

Loading

dmytro-ndp Aug 7, 2019 •

edited

Loading

dmytro-ndp Aug 7, 2019 •

edited

Loading

dmytro-ndp Aug 7, 2019 •

edited

Loading