Add ability to configure workspace ephemeral mode #12483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashumilova
added
the
kind/enhancement
che-bot
added
the
status/code-review
|
ci-test |
|
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
|
ci-build |
benoitf
approved these changes
Jan 21, 2019
| onEphemeralModeChange(): void { | ||
| debugger; | ||
| if (this.isEphemeralMode) { | ||
| this.workspaceDetails.config.attributes.persistVolumes = true + ''; |
| this.workspaceDetails.config.attributes.persistVolumes = true + ''; | ||
| } else { | ||
| if (this.attributesCopy.persistVolumes) { | ||
| this.workspaceDetails.config.attributes.persistVolumes = false + ''; |
There was a problem hiding this comment.
'false' ?
false.toString() ?
akurinnoy
approved these changes
Jan 22, 2019
Signed-off-by: Anna Shumilova <[email protected]>
olexii4
approved these changes
Jan 22, 2019
olexii4
approved these changes
Jan 22, 2019
|
ci-test |
|
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anna Shumilova [email protected]
What does this PR do?
Adds ability to configure workspace ephemeral mode for workspace on Overview page.
What issues does this PR fix or reference?
#12374
Release Notes
Docs PR