-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add attributes to Che 7 plugin meta; make URL field not mandatory #12148
Conversation
Signed-off-by: Oleksandr Garagatyi <[email protected]>
ci-test |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO it looks strange to have check for null attributes on getter while it's initialized on class to a value. Probably check on setter or not have hashmap initialized when defining the attributes ?
...workspace/src/main/java/org/eclipse/che/api/workspace/server/wsplugins/model/PluginMeta.java
Outdated
Show resolved
Hide resolved
@benoitf we have this type of code all over the place in Che. I agree that approach suggested by you might be better. Would be better to discuss this as a separate topic with those who write server-side components and agree on what approach to use everywhere. |
@benoitf As far as I remember we had issues with equals on POJOs before. In a case, when one POJO instance is initialized with null or without value and another one has initialized with empty map these objects are not equal. But we never return null as a collection, so when such a POJO is used it should be an equal object. So, we either need to ensure that collection is initialized on getter and use it in equals method or we need to initialize it with an empty map and reinitialize it on setting null as a map. |
ci-test |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
What does this PR do?
Add attributes to Che 7 plugin meta; make URL field not mandatory.
This is needed for implementation of VS Code extension broker.
What issues does this PR fix or reference?
Release Notes
Docs PR