Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Che releases be GH releases (and thus update the 'latest release' metadata) ? #17177

Closed
sparkoo opened this issue Jun 17, 2020 · 14 comments
Labels
area/ci CI build and releases, PR testing, & whitelabel/productization issues

Comments

@sparkoo
Copy link
Member

sparkoo commented Jun 17, 2020

Describe the bug

on github repo page https://github.com/eclipse/che , the latest release is Eclipse CHE 5.15.0. I guess since then, we only do tags, but did not properly marked as a release on github.

Che version

all of them

Steps to reproduce

go to https://github.com/eclipse/che

Expected behavior

latest release should be latest release

Screenshots

20200617_170226_1498x687_scrot

@sparkoo sparkoo added the kind/bug Outline of a bug - must adhere to the bug report template. label Jun 17, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jun 17, 2020
@l0rd
Copy link
Contributor

l0rd commented Jun 17, 2020

@sparkoo that makes sense but I am not able to see the About panel that you have in your screenshot. This is what I see:

image

And if I click on releases:

image

@l0rd l0rd added status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jun 17, 2020
@sparkoo
Copy link
Member Author

sparkoo commented Jun 18, 2020

Yes, I have some new beta github repo page, which you have to opt-in now. I guess we all get it sooner or later without option to opt-out.

Another issue with this is alias link to latest release /releases/latest, which may be used to some automation https://github.com/eclipse/che/releases/latest

@benoitf
Copy link
Contributor

benoitf commented Jun 18, 2020

I manually created a more recent release but I guess the release script should do this automation
cc @mkuznyetsov @nickboldt

image

@benoitf benoitf added area/ci CI build and releases, PR testing, & whitelabel/productization issues area/productization and removed status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. labels Jun 18, 2020
@nickboldt nickboldt changed the title Latest releast on github is Eclipse CHE 5.15.0 Should Che releases be GH releases (and thus update the 'latest release' metadata) ? Jun 21, 2020
@nickboldt nickboldt removed the kind/bug Outline of a bug - must adhere to the bug report template. label Jun 21, 2020
@nickboldt
Copy link
Contributor

nickboldt commented Jun 21, 2020

I've renamed this issue and added it to the current list of improvements to the Che release process so that @mkuznyetsov sees this and can comment on its usefulness. See #17101

@nickboldt
Copy link
Contributor

Do we need "actual releases" or are tags w/ source tarballs good enough for now?

image

@nickboldt
Copy link
Contributor

nickboldt commented Feb 8, 2021

Are the current releases generated or manually created by @sparkoo ?

image

Unclear what the value is of having a "release" vs. a "tag". @sparkoo can you explain if this is still something we need to do in Che release process?

For example, does anyone use https://github.com/eclipse/che/releases/latest ?

@sparkoo
Copy link
Member Author

sparkoo commented Feb 10, 2021

@nickboldt yes, I'm doing those manually on very random basis. /latest is one feature. You can also watch for releases on the repo. Me personally I like to look at main repo page and see what's the latest version (see the screenshot in issue description #17177 (comment)). I'd like to see it automated, but looks like I'm the only one...

@nickboldt
Copy link
Contributor

what do you DO with those releases? is it for knowing when to update to newer Che ?

Or just to know when release is done? If the latter, see #17579 -- maybe you just want timely notifications of release status ?

@benoitf
Copy link
Contributor

benoitf commented Feb 22, 2021

it should be a post-action of the release script

It's to tell the world that we've release a new version of Che (and include release notes)

@nickboldt
Copy link
Contributor

nickboldt commented Feb 22, 2021

include release notes?? I don't think we've been doing that for over a year.

https://developers.redhat.com/blog/2018/06/08/eclipse-che-6-6-release-notes/
https://medium.com/eclipse-che-blog/eclipse-che-6-15-6-16-and-6-17-release-notes-362cff44dcc9

https://github.com/eclipse/che/blob/master/CHANGELOG.md (last updated for 7.4)

How will we generate release notes? will it be a raw dump of "all issues closed in this milestone" ? or a live query to "all issues closed for milestone ___" so that those not closed at the time of the release can be added into the notes when closed?

What about 7.yy.z releases? should those also have release notes and if so, how do we track/record what's fixed in those, as we don't use milestone field for .z releases?

Release note generation is not in scope for this issue, as there are too many questions to answer first about how/what/how many involved in that. If you think the community would benefit from snapshots of issues lists taken at the time of release (vs. having live queries) then could you open a new issue for that?

@benoitf
Copy link
Contributor

benoitf commented Feb 23, 2021

@nickboldt release notes is a separate issue. But generating github release is part of the release script (or the github action that creates the tag on che repository)

@sparkoo
Copy link
Member Author

sparkoo commented Feb 23, 2021

what do you DO with those releases? is it for knowing when to update to newer Che ?

Or just to know when release is done? If the latter, see #17579 -- maybe you just want timely notifications of release status ?

I don't do anything with those releases. I personally use it mostly to take a quick look what's the latest Che released version. Github main repo is convenient place for it as I have it open all the time. I don't need any reporting or anything like that.

From outsider's perspective, I use releases in other projects on github very often. Just go to the project repo and see the latest version or see when some exact version was released. If there is an older version than latest, I would never know. If I'm interested in seeing newer releases, I can subscribe to releases only on github.

There is simple GH action to create a release from tag https://github.com/actions/create-release so we could just add it as a next step in the release action. If there is some big resistance to have releases on github, I would vote to remove all the releases, so it is clear we're not using them. But this half-way state is not good for anybody.

@nickboldt
Copy link
Contributor

Well, if it was that simple... why not just contribute the fix?

#19211

Voila!

nickboldt added a commit that referenced this issue Mar 5, 2021
* create a GH release every time we release the che server artifacts

Change-Id: Id341d99d321f4ec2cecb2687169e4dbf64a53edf
Signed-off-by: nickboldt <[email protected]>

* use input version for tag and release names (not sure if that's better)

Change-Id: Ie86d2f2d3133dbe71cd1a2d48db5bc58d082a746
Signed-off-by: nickboldt <[email protected]>
@nickboldt
Copy link
Contributor

nickboldt commented Mar 12, 2021

I'm marking this done, even though the changelog we're now generating for releases has alots of dupe content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci CI build and releases, PR testing, & whitelabel/productization issues
Projects
None yet
Development

No branches or pull requests

5 participants