Fix security vulnerability and Dashboard's workspace detail page (#14644

) * activate first tab on workspace detals page if no query params were passed Signed-off-by: Oleksii Kurinnyi <[email protected]> * update axios version to fix high security vulnerability Signed-off-by: Oleksii Kurinnyi <[email protected]>
eclipse-che · Sep 26, 2019 · ece3257 · ece3257
1 parent 8fd46cd
commit ece3257
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 32 deletions.
diff --git a/dashboard/src/app/workspaces/workspace-details/workspace-details.controller.ts b/dashboard/src/app/workspaces/workspace-details/workspace-details.controller.ts
@@ -221,10 +221,8 @@ export class WorkspaceDetailsController {
    * @param {string} tab
    */
   updateSelectedTab(tab: string): void {
-    const value = this.tab[tab];
-    if (angular.isDefined(value)) {
-      this.selectedTabIndex = parseInt(value, 10);
-    }
+    const tabIndex = parseInt(this.tab[tab], 10);
+    this.selectedTabIndex = isNaN(tabIndex) ? 0 : tabIndex;
   }
 
   /**

diff --git a/e2e/package-lock.json b/e2e/package-lock.json
diff --git a/e2e/package.json b/e2e/package.json
@@ -23,7 +23,7 @@
     "@types/node": "^11.13.4",
     "@types/rimraf": "^2.0.2",
     "@types/selenium-webdriver": "^3.0.16",
-    "axios": "0.17.1",
+    "axios": "0.18.1",
     "chai": "^4.2.0",
     "chromedriver": "^76.0.0",
     "mocha": "^6.1.4",