This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Use terminal widget for output rendering in the task plugin #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
AndrienkoAleksandr
requested review from
evidolob,
RomanNikitenko,
mmorhun and
akurinnoy
AndrienkoAleksandr
requested review from
olexii4,
sunix and
vitaliy-guliy
as code owners
benoitf
reviewed
May 16, 2019
| cwd: target.workingDir, | ||
| name: taskConfig.label, | ||
| shellPath: 'sh', | ||
| shellArgs: ['-c', "'" + taskConfig.command + "'"], |
There was a problem hiding this comment.
shouldn't we use string literals ?
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
|
Is it possible to reuse widget for the same task if task was completed? |
There was a problem hiding this comment.
@AndrienkoAleksandr
I tested your changes and tried to run a task in ws/dev container, but it always was run in theia-ide container.
Could you test this case?
Please see video https://youtu.be/qooQnIPSKNI
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Thanks a lot. Fixed! |
evidolob
approved these changes
May 17, 2019
RomanNikitenko
approved these changes
May 17, 2019
mmorhun
approved these changes
May 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Proposed changes:
What issues does this PR fix or reference?
#192