Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

chore: initialize workspace properly if git repository does not contain .vscode/extensions.json #1352

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

vitaliy-guliy
Copy link
Contributor

Signed-off-by: Vitaliy Gulyy [email protected]

What does this PR do?

Initializes devWorkspace with empty extension list to be able to add extensions on demand.

Screenshot/screencast of this PR

Screenshot from 2022-06-08 18-17-29

What issues does this PR fix or reference?

eclipse-che/che#21422

How to test this PR?

Following flow to test on local minikube deployment:

  • clone che-theia, run yarn
  • clone che-dashboard, run yarn to install dependencies
  • overwrite che-dashboard/node_modules/@eclipse-che/che-theia-devworkspace-handler/lib with che-theia/tools/devworkspace-handler/lib
  • go to che-dashboard/packages/dashboard-frontend, run yarn build
  • go to che-dashboard, run
yarn start:prepare
yarn start

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

…gins/extensions provided

Signed-off-by: Vitaliy Gulyy <[email protected]>
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #1352 (17abbf1) into main (c299f59) will increase coverage by 3.96%.
The diff coverage is 39.34%.

@@            Coverage Diff             @@
##             main    #1352      +/-   ##
==========================================
+ Coverage   32.78%   36.74%   +3.96%     
==========================================
  Files         290      330      +40     
  Lines        9885    11394    +1509     
  Branches     1457     1572     +115     
==========================================
+ Hits         3241     4187     +946     
- Misses       6641     7202     +561     
- Partials        3        5       +2     
Impacted Files Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx 0.00% <0.00%> (ø)
...credentials/src/browser/che-credentials-service.ts 0.00% <0.00%> (ø)
...entials/src/browser/credentials-frontend-module.ts 0.00% <0.00%> (ø)
...eia-credentials/src/common/credentials-protocol.ts 0.00% <0.00%> (ø)
...eia-credentials/src/node/che-credentials-server.ts 0.00% <0.00%> (ø)
...s/src/node/che-theia-credentials-backend-module.ts 0.00% <0.00%> (ø)
...ashboard/src/browser/che-theia-dashboard-module.ts 0.00% <0.00%> (ø)
...ia-dashboard/src/browser/theia-dashboard-client.ts 0.00% <0.00%> (ø)
...rowser/src/browser/che-mini-browser-environment.ts 0.00% <0.00%> (ø)
...in-ext/src/browser/che-sidecar-file-system-main.ts 100.00% <ø> (ø)
... and 296 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e60a2df...17abbf1. Read the comment docs.

Copy link
Contributor

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svor svor merged commit 321ff14 into main Jun 28, 2022
@svor svor deleted the fix-sidecar-plugin-installation branch June 28, 2022 14:23
@che-bot che-bot added this to the 7.50 milestone Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants