Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

chore: [dev-workspace] Rework SSH plugin to store keys in the K8s secret #1277

Merged
merged 18 commits into from
Jan 20, 2022
Merged

chore: [dev-workspace] Rework SSH plugin to store keys in the K8s secret #1277

merged 18 commits into from
Jan 20, 2022

Conversation

vinokurig
Copy link
Contributor

What does this PR do?

  • Rework SSH plugin to store keys in the K8s secret
  • Generate SSH keys using the container tools instead of CHE API requests

Todo: uncomment the GitHub Communds when eclipse-che/che#20860 is done.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes eclipse-che/che#20859

How to test this PR?

  1. Start the dev-workspce environment
  2. Try the SSH plugin functions.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

@che-bot
Copy link
Contributor

che-bot commented Dec 17, 2021

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia quay.io/crw_pr/che-theia:1277
che-theia-endpoint-runtime-binary quay.io/crw_pr/che-theia-endpoint-runtime-binary:1277

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@codecov
Copy link

codecov bot commented Dec 17, 2021 •
edited
Loading

Codecov Report

Merging #1277 (0f13201) into main (c299f59) will increase coverage by 3.07%.
The diff coverage is 30.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1277      +/-   ##
==========================================
+ Coverage   32.78%   35.86%   +3.07%     
==========================================
  Files         290      326      +36     
  Lines        9885    10726     +841     
  Branches     1457     1441      -16     
==========================================
+ Hits         3241     3847     +606     
- Misses       6641     6874     +233     
- Partials        3        5       +2
Impacted Files Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx 0.00% <0.00%> (ø)
...credentials/src/browser/che-credentials-service.ts 0.00% <0.00%> (ø)
...entials/src/browser/credentials-frontend-module.ts 0.00% <0.00%> (ø)
...eia-credentials/src/common/credentials-protocol.ts 0.00% <0.00%> (ø)
...eia-credentials/src/node/che-credentials-server.ts 0.00% <0.00%> (ø)
...s/src/node/che-theia-credentials-backend-module.ts 0.00% <0.00%> (ø)
...ashboard/src/browser/che-theia-dashboard-module.ts 0.00% <0.00%> (ø)
...ia-dashboard/src/browser/theia-dashboard-client.ts 0.00% <0.00%> (ø)
...rowser/src/browser/che-mini-browser-environment.ts 0.00% <0.00%> (ø)
...in-ext/src/browser/che-sidecar-file-system-main.ts 100.00% <ø> (ø)
... and 294 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1479089...0f13201. Read the comment docs.

@svor
Copy link
Contributor

svor commented Dec 20, 2021

I suggest to wait when github-oauth plugin will be adapted to don't break the current state of the github functionality.
@vinokurig @benoitf wdyt?

@che-bot
Copy link
Contributor

che-bot commented Dec 21, 2021

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia quay.io/crw_pr/che-theia:1277
che-theia-endpoint-runtime-binary quay.io/crw_pr/che-theia-endpoint-runtime-binary:1277

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@che-bot
Copy link
Contributor

che-bot commented Dec 22, 2021

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia quay.io/crw_pr/che-theia:1277
che-theia-endpoint-runtime-binary quay.io/crw_pr/che-theia-endpoint-runtime-binary:1277

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@vinokurig
Copy link
Contributor Author

depends on eclipse-che/che#20844

@svor
Copy link
Contributor

svor commented Dec 22, 2021

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Dec 22, 2021

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia quay.io/crw_pr/che-theia:1277
che-theia-endpoint-runtime-binary quay.io/crw_pr/che-theia-endpoint-runtime-binary:1277

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@che-bot
Copy link
Contributor

che-bot commented Dec 23, 2021

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia quay.io/crw_pr/che-theia:1277
che-theia-endpoint-runtime-binary quay.io/crw_pr/che-theia-endpoint-runtime-binary:1277

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@svor svor mentioned this pull request Jan 12, 2022
Closed
17 tasks
svor
svor approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinokurig
Copy link
Contributor Author

depends on devfile/devworkspace-operator#732

@vinokurig vinokurig merged commit 9370e04 into main Jan 20, 2022
@vinokurig vinokurig deleted the che-20859 branch January 20, 2022 14:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benoitf benoitf benoitf approved these changes

@svor svor svor approved these changes

@tsmaeder tsmaeder Awaiting requested review from tsmaeder

@vitaliy-guliy vitaliy-guliy Awaiting requested review from vitaliy-guliy vitaliy-guliy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[devWorkspace] Adapt ssh-plugin to avoid requesting che-server API
4 participants
@vinokurig @che-bot @svor @benoitf