Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Handle the changes introduced by upstream theia with allowing multiple clients on plug-ins #110

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Mar 14, 2019

Also require to merge first eclipse-theia/theia#4562

Should fix also the sidecar reloading issue eclipse-theia/theia#3970

in improvements, manage clearly reloading of plug-ins from sidecar and ensure plug-ins are correctly stopped.

@benoitf
Copy link
Contributor Author

benoitf commented Mar 14, 2019

It's fixing also the issue with more than one plug-in per side-car.

Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@benoitf
Copy link
Contributor Author

benoitf commented Mar 14, 2019

ci-build

@benoitf benoitf force-pushed the per-connection-scoped branch from 6016e3a to 6dbe3a5 Compare March 14, 2019 16:51
@benoitf benoitf merged commit 7d8950b into master Mar 14, 2019
@benoitf benoitf deleted the per-connection-scoped branch March 14, 2019 16:59
@azatsarynnyy
Copy link
Member

@benoitf I've tested it with the Kubernetes Plugin. Everything works fine until I refresh the page.
After refreshing it and executing a command from palette, I've got the error in the plugin container:

error socket while sending Error: WebSocket is not open: readyState 3 (CLOSED)
    at WebSocket.send (/home/theia/node_modules/ws/lib/websocket.js:314:19)
    at WebSocketClient.send (/home/theia/lib/node/plugin-remote-init.js:305:25)
    at Object.send (/home/theia/lib/node/plugin-remote-init.js:203:33)
    at RPCMultiplexer.sendAccumulated (/home/theia/node_modules/@theia/plugin-ext/lib/api/rpc-protocol.js:208:25)
    at runCallback (timers.js:810:20)
    at tryOnImmediate (timers.js:768:5)
    at processImmediate [as _immediateCallback] (timers.js:745:5) [ '{"hostID":"ws___csuehxdebh_5690","type":1,"id":"180","proxyId":"QuickOpenMain","method":"$input","args":[{"prompt":"What namespace do you want to use?","placeHolder":"Enter the namespace to switch to or press enter to select from available list"},false]}' ]

@benoitf
Copy link
Contributor Author

benoitf commented Mar 15, 2019

@azatsarynnyy ok :-/ will try to reproduce and analyze it further

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants