Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit extracting subfolder from a workspace URL #523

Merged
merged 4 commits into from
Jun 15, 2023
Merged

Omit extracting subfolder from a workspace URL #523

merged 4 commits into from
Jun 15, 2023

Conversation

vinokurig
Copy link
Contributor

What does this PR do?

sparce-checkoutis no longer available from devfile 2.1, so omit the subfolder mechanism in order to support branch names with a / sign.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes eclipse-che/che#21706

How to test this PR?

  1. Create branch with a / sign in GitHub or GitLab repo
  2. Start a workspace from the branch URl

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@openshift-ci openshift-ci bot added the lgtm label Jun 14, 2023
@ibuziuk ibuziuk requested a review from artaleks9 June 14, 2023 13:06
@artaleks9
Copy link
Contributor

Verified on Che deployed with quay.io/eclipse/che-server:pr-523 image, works properly:

che-server-pr-523

@openshift-ci
Copy link

openshift-ci bot commented Jun 15, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: artaleks9, tolusha, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vinokurig vinokurig merged commit ab83bee into main Jun 15, 2023
@vinokurig vinokurig deleted the che-21706 branch June 15, 2023 10:41
@devstudio-release
Copy link

Build 3.8 :: server_3.x/181: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.8 :: server_3.x/181: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/3681 triggered

@devstudio-release
Copy link

Build 3.8 :: update-digests_3.x/3506: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.8 :: update-digests_3.x/3506: UNSTABLE

No new images detected: nothing to do!

@devstudio-release
Copy link

Build 3.8 :: server_3.x/182: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.8 :: server_3.x/182: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/3704 triggered

@devstudio-release
Copy link

Build 3.8 :: update-digests_3.x/3551: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.8 :: get-sources-rhpkg-container-build_3.x/3556: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 53544236 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Devfile could not be found in the branch which name contains '/' sign
4 participants