Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support git+ssh urls #458

Merged
merged 5 commits into from
Mar 9, 2023
Merged

feat: Support git+ssh urls #458

merged 5 commits into from
Mar 9, 2023

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Mar 6, 2023

What does this PR do?

feat: Support git+ssh urls

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#22025

How to test this PR?

  1. Deploy Eclipse Che chectl server:deploy --platform <...> --cheimage quay.io/abazko/che-server:22025
  2. Configuring DevWorkspaces to use SSH keys for Git operations
  3. Start a workspace with url https://<che-host>/dashboard/#/load-factory?url=<git+ssh_url_to_private_repo>

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@tolusha tolusha marked this pull request as ready for review March 7, 2023 08:29

@Override
public String fileContent(@NotNull String repository, @NotNull String filePath) {
return "";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some javadoc or todo to describe why the file content is empty

@ibuziuk
Copy link
Member

ibuziuk commented Mar 8, 2023

@tolusha great job, but looks like there is some build issue (formatting or license check I guess)

tolusha added 4 commits March 9, 2023 10:01
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
@tolusha tolusha merged commit 04bf956 into main Mar 9, 2023
@tolusha tolusha deleted the 22025 branch March 9, 2023 12:24
@devstudio-release
Copy link

Build 3.6 :: server_3.x/134: Console, Changes, Git Data

@che-bot che-bot added this to the 7.63 milestone Mar 9, 2023
@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.6 :: update-digests_3.x/2434: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.6 :: server_3.x/134: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/2668 triggered

@devstudio-release
Copy link

Build 3.6 :: operator-bundle_3.x/997: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.6 :: copyIIBsToQuay/1136: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.6 :: sync-to-downstream_3.x/2670: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/2518 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.6 :: operator-bundle_3.x/997: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/2670 triggered

@devstudio-release
Copy link

Build 3.6 :: dsc_3.x/703: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.6 :: update-digests_3.x/2434: SUCCESS

Detected new images: rebuild operator-bundle
* server; /DS_CI/operator-bundle_3.x/997 triggered

@devstudio-release
Copy link

Build 3.6 :: dsc_3.x/703: SUCCESS

3.6.0 CI

@devstudio-release
Copy link

Build 3.6 :: copyIIBsToQuay/1136: SUCCESS

3.6
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.6-97
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:0.19-4
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.6-v4.13-449504-440885-ppc64le
  + quay.io/devspaces/iib:3.6-v4.13-ppc64le
  + quay.io/devspaces/iib:next-v4.13-ppc64le
  + quay.io/devspaces/iib:3.6-v4.12-449496-440880-ppc64le
  + quay.io/devspaces/iib:3.6-v4.12-ppc64le
  + quay.io/devspaces/iib:next-v4.12-ppc64le
  + quay.io/devspaces/iib:3.6-v4.11-449678-440871-ppc64le
  + quay.io/devspaces/iib:3.6-v4.11-ppc64le
  + quay.io/devspaces/iib:next-v4.11-ppc64le
  + quay.io/devspaces/iib:3.6-v4.10-449673-440866-ppc64le
  + quay.io/devspaces/iib:3.6-v4.10-ppc64le
  + quay.io/devspaces/iib:next-v4.10-ppc64le
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.6-v4.13-449504-440885-s390x
  + quay.io/devspaces/iib:3.6-v4.13-s390x
  + quay.io/devspaces/iib:next-v4.13-s390x
  + quay.io/devspaces/iib:3.6-v4.12-449496-440880-s390x
  + quay.io/devspaces/iib:3.6-v4.12-s390x
  + quay.io/devspaces/iib:next-v4.12-s390x
  + quay.io/devspaces/iib:3.6-v4.11-449678-440871-s390x
  + quay.io/devspaces/iib:3.6-v4.11-s390x
  + quay.io/devspaces/iib:next-v4.11-s390x
  + quay.io/devspaces/iib:3.6-v4.10-449673-440866-s390x
  + quay.io/devspaces/iib:3.6-v4.10-s390x
  + quay.io/devspaces/iib:next-v4.10-s390x
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.6-v4.13-449504-440885-x86_64
  + quay.io/devspaces/iib:3.6-v4.13-x86_64
  + quay.io/devspaces/iib:next-v4.13-x86_64
  + quay.io/devspaces/iib:3.6-v4.12-449688-440880-x86_64
  + quay.io/devspaces/iib:3.6-v4.12-x86_64
  + quay.io/devspaces/iib:next-v4.12-x86_64
  + quay.io/devspaces/iib:3.6-v4.11-449678-440871-x86_64
  + quay.io/devspaces/iib:3.6-v4.11-x86_64
  + quay.io/devspaces/iib:next-v4.11-x86_64
  + quay.io/devspaces/iib:3.6-v4.10-449673-440866-x86_64
  + quay.io/devspaces/iib:3.6-v4.10-x86_64
  + quay.io/devspaces/iib:next-v4.10-x86_64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants