-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support git+ssh urls #458
Conversation
|
||
@Override | ||
public String fileContent(@NotNull String repository, @NotNull String filePath) { | ||
return ""; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some javadoc or todo
to describe why the file content is empty
@tolusha great job, but looks like there is some build issue (formatting or license check I guess) |
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Build 3.6 :: server_3.x/134: Console, Changes, Git Data |
Build 3.6 :: sync-to-downstream_3.x/2668: Console, Changes, Git Data |
Build 3.6 :: push-latest-container-to-quay_3.x/1912: Console, Changes, Git Data |
Build 3.6 :: get-sources-rhpkg-container-build_3.x/2516: server : 3.x :: Build 51217545 : quay.io/devspaces/server-rhel8:3.6-22 |
Build 3.6 :: update-digests_3.x/2434: Console, Changes, Git Data |
Build 3.6 :: server_3.x/134: Upstream sync done; /DS_CI/sync-to-downstream_3.x/2668 triggered |
Build 3.6 :: operator-bundle_3.x/997: Console, Changes, Git Data |
Build 3.6 :: sync-to-downstream_3.x/2670: Console, Changes, Git Data |
Build 3.6 :: push-latest-container-to-quay_3.x/1913: Console, Changes, Git Data |
Build 3.6 :: copyIIBsToQuay/1136: Console, Changes, Git Data |
Build 3.6 :: sync-to-downstream_3.x/2670: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/2518 triggered; /job/DS_CI/job/dsc_3.x triggered; |
Build 3.6 :: operator-bundle_3.x/997: Upstream sync done; /DS_CI/sync-to-downstream_3.x/2670 triggered |
Build 3.6 :: dsc_3.x/703: Console, Changes, Git Data |
Build 3.6 :: update-digests_3.x/2434: Detected new images: rebuild operator-bundle |
Build 3.6 :: dsc_3.x/703: 3.6.0 CI |
What does this PR do?
feat: Support git+ssh urls
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
eclipse-che/che#22025
How to test this PR?
chectl server:deploy --platform <...> --cheimage quay.io/abazko/che-server:22025
https://<che-host>/dashboard/#/load-factory?url=<git+ssh_url_to_private_repo>
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.