chore: Refactore the factory flow to pick out the authentication logic to a separate API method #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c to a separate API method
vinokurig
requested review from
mshaposhnik,
nickboldt,
skabashnyuk,
amisevsk and
metlos
as code owners
tolusha
reviewed
Sep 19, 2022
...er/che-core-api-factory/src/main/java/org/eclipse/che/api/factory/server/FactoryService.java
Outdated
Show resolved
Hide resolved
tolusha
reviewed
Sep 19, 2022
...er/che-core-api-factory/src/main/java/org/eclipse/che/api/factory/server/FactoryService.java
Outdated
Show resolved
Hide resolved
tolusha
reviewed
Sep 19, 2022
...er/che-core-api-factory/src/main/java/org/eclipse/che/api/factory/server/FactoryService.java
Outdated
Show resolved
Hide resolved
…i/factory/server/FactoryService.java Co-authored-by: Anatolii Bazko <[email protected]>
tolusha
approved these changes
Sep 19, 2022
…on logic to a separate API method
vinokurig
force-pushed
the
che-21640
branch
from
4bad553 to
45e7fc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The API method is going to be used for the token verification step when a factory is restarted from dashboard.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#21640
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.