fix: Allow to get files from git repository if file name starts with dot #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaliy-guliy
requested review from
mshaposhnik and
nickboldt
as code owners
|
This needs to be backported to 7.52.x branch for DS 3.2. |
tolusha
reviewed
Sep 8, 2022
| // since files retrieved via REST, we cannot use path symbols like . ./ so cut them off | ||
| requestURL = remoteFactoryUrl.rawFileLocation(fileURL.replaceAll("^[/.]+", "")); | ||
| // since files retrieved via REST, we cannot use path like '.' or one that starts with './' | ||
| // or '../', so cut them off |
There was a problem hiding this comment.
If we cut ../ of then we will have a wrong location, right?
There was a problem hiding this comment.
We addressing the resource, beginning from the repository root, and this cutting does not change anything.
But yes, it looks a bit confusing, just take a look at the test https://github.com/eclipse-che/che-server/blob/main/wsmaster/che-core-api-factory-bitbucket-server/src/test/java/org/eclipse/che/api/factory/server/bitbucket/BitbucketServerAuthorizingFileContentProviderTest.java#L115
Let me try to remove cutting of ../, update the PR and republish che-server image, that is used to test.
Signed-off-by: Vitaliy Gulyy <[email protected]>
vitaliy-guliy
force-pushed
the
che-21635
branch
from
723d332 to
feb6310
Compare
tolusha
approved these changes
Sep 9, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vitaliy Gulyy [email protected]
What does this PR do?
Fixes retrieving files from git repository when filename or directory name starts with dots.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
Fixes eclipse-che/che#21635, and potentially eclipse-che/che#21639
How to test this PR?
Create a workspace with a factory
https://github.com/che-samples/java-spring-petclinic/tree/devfilev2?che-editor=eclipse/che-theia/next
Open Plugins view, check for installed plugins. Open terminal in editor container, check for
.vsixfiles existence in/plugins/sidecars/toolsdirectory.PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.