Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vscode-xml to 0.16.1 #929

Merged
merged 2 commits into from
May 20, 2021
Merged

Update vscode-xml to 0.16.1 #929

merged 2 commits into from
May 20, 2021

Conversation

ericwill
Copy link
Contributor

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ericwill

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ericwill
Copy link
Contributor Author

This plugin will fail if telemetry from vscode-commons is not installed. So this PR is blocked by eclipse-che/che#19361

@ericwill
Copy link
Contributor Author

Marking as draft until we have vscode-commons support in Che.

@ericwill ericwill marked this pull request as draft April 26, 2021 19:32
@ericwill ericwill marked this pull request as ready for review May 18, 2021 19:01
@openshift-ci
Copy link

openshift-ci bot commented May 20, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ericwill, svor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label May 20, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 20, 2021

New changes are detected. LGTM label has been removed.

@ericwill ericwill changed the title Update vscode-xml to 0.16.0 Update vscode-xml to 0.16.1 May 20, 2021
@ericwill
Copy link
Contributor Author

Updated to 0.16.1 to get the fix from redhat-developer/vscode-xml#476

@openshift-ci
Copy link

openshift-ci bot commented May 20, 2021

@ericwill: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/v7-plugins-test-pr-check 0be2ebf link /test v7-plugins-test-pr-check

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericwill ericwill merged commit fc80cb7 into eclipse-che:master May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade VS Code xml from 0.14 to 0.16
3 participants