Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vscode-java to 0.82 #1060

Merged
merged 2 commits into from
Dec 17, 2021
Merged

Conversation

tsmaeder
Copy link
Contributor

Signed-off-by: Thomas Mäder <[email protected]>
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

Copy link
Contributor

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revision: v0.75.0 should be updated as well

Signed-off-by: Thomas Mäder <[email protected]>
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@svor
Copy link
Contributor

svor commented Dec 15, 2021

/retest

@benoitf
Copy link
Contributor

benoitf commented Dec 15, 2021

since that PR has been created, VS Code java is at revision 1.1.0

@svor
Copy link
Contributor

svor commented Dec 15, 2021

since that PR has been created, VS Code java is at revision 1.1.0

@benoitf this PR was created a long time ago and the idea was to finish that work and apply vscode-java v0.82 which should work without some unexpected issues.

@svor
Copy link
Contributor

svor commented Dec 15, 2021

We can apply current changes and update to the latest version in the future

Copy link
Contributor

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some problems with the plugin initialization:
screenshot-che-eclipse-che 192 168 49 2 nip io-2021 12 15-20_42_49

ERROR:Activating extension 'Language Support for Java(TM) by Red Hat' failed:TypeError: Class extends value undefined is not a constructor or null
ERROR:Activating extension 'Java Test Runner' failed:Error: Dependent extension 'Language Support for Java(TM) by Red Hat' failed to activate.

@tsmaeder
Copy link
Contributor Author

@svor yes, I put a comment in the issue.

@tsmaeder
Copy link
Contributor Author

/retest

Copy link
Contributor

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on https://che-dogfooding.apps.che-dev.x6e0.p1.openshiftapps.com/ with che-theia:next and I didn't detect any problem:

Screenshot from 2021-12-17 16-13-20

@openshift-ci openshift-ci bot added the lgtm label Dec 17, 2021
@openshift-ci
Copy link

openshift-ci bot commented Dec 17, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: svor, tsmaeder

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants