-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vscode-java to 0.82 #1060
Conversation
Signed-off-by: Thomas Mäder <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revision: v0.75.0
should be updated as well
Signed-off-by: Thomas Mäder <[email protected]>
/retest |
since that PR has been created, VS Code java is at revision |
@benoitf this PR was created a long time ago and the idea was to finish that work and apply vscode-java v0.82 which should work without some unexpected issues. |
We can apply current changes and update to the latest version in the future |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see some problems with the plugin initialization:
ERROR:Activating extension 'Language Support for Java(TM) by Red Hat' failed:TypeError: Class extends value undefined is not a constructor or null
ERROR:Activating extension 'Java Test Runner' failed:Error: Dependent extension 'Language Support for Java(TM) by Red Hat' failed to activate.
@svor yes, I put a comment in the issue. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on https://che-dogfooding.apps.che-dev.x6e0.p1.openshiftapps.com/ with che-theia:next and I didn't detect any problem:
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: svor, tsmaeder The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Thomas Mäder [email protected]
What does this PR do?
Updates vscode-java to the latest version (0.8.2)
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#20134
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.