Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the default value for openShiftoAuth to true #391

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Aug 6, 2020

Signed-off-by: Anatolii Bazko [email protected]

Reference issue

eclipse-che/che#17488

What does this PR do

Set the default value for openShiftoAuth to true

Copy link
Contributor

@davidfestal davidfestal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we check that it doesn't impact the raw Kubernetes case ?

@tolusha
Copy link
Contributor Author

tolusha commented Aug 6, 2020

It shouldn't since everything is protected by if isOpenShift clause in the operator code.
But I will do some tests.

@tolusha
Copy link
Contributor Author

tolusha commented Aug 6, 2020

@davidfestal
everything works fine

@flacatus
Copy link
Contributor

flacatus commented Aug 6, 2020

I did as well some tests in cluster bot OCP 4.5 and works...

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, davidfestal, flacatus, tolusha
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha tolusha merged commit bd8679d into master Aug 10, 2020
@tolusha tolusha deleted the setosoauthtrue branch August 10, 2020 07:01
@che-bot che-bot added this to the 7.18 milestone Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants