-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate custom CA certificate into Keycloak trust store #267
Conversation
The changes will be included in another PR. |
Retested: certificates propagation into Keycloak trust store works as expected. |
828e94b
to
090a630
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with just a question
addCertToTrustStoreCommand := addRouterCrt + " && " + addOpenShiftAPICrt + " && " + addMountedCrt + " && " + addMountedServiceCrt + " && " + importJavaCacerts | ||
customPublicCertsDir := "/public-certs" | ||
customPublicCertsVolumeSource := corev1.VolumeSource{} | ||
if checluster.Spec.Server.ServerTrustStoreConfigMapName != "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you preferred creating the volume in any case and leaving the volume source empty in case no public certificate is provided ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right
Signed-off-by: Anatoliy Bazko <[email protected]>
Signed-off-by: Mykola Morhun [email protected]
What this PR does
We have
serverTrustStoreConfigMapName
parameter in Che CR, which hold name of config map with custom CA certificates. They are added into Che server trust store only, but to fully support trusting to custom CA certificates we need to propagate them into Keycloak and user workspaces.This PR adds functionality which propagates custom CA certificates into Keycloak trust store.
Reference issue
https://issues.redhat.com/browse/CRW-336
How to test
This could be done via
kubectl apply -f <yaml>
where the config map definition could be like:serverTrustStoreConfigMapName
underspec.server
. Or this could be done by providing--che-operator-cr-patch-yaml
option to chectl. Pathc file content: