Add s390x support with docker buildx #251
Conversation
shahidhs-ibm
requested review from
davidfestal,
l0rd,
nickboldt,
rhopp,
tolusha and
vparfonov
as code owners
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
.github/workflows/build.yml
Outdated
| uses: actions/checkout@v2 | ||
| - name: install buildx | ||
| id: buildx | ||
| uses: crazy-max/ghaction-docker-buildx@v1 |
There was a problem hiding this comment.
Could you explain why do we need buildx ?
There was a problem hiding this comment.
buildx is an experimental docker client tool for multiarch builds on a single arch.
@shahidhs-ibm can you talk to your colleagues about ppc64le support? It would be great to get a single PR for both Z and Power...
There was a problem hiding this comment.
FYI, We've use buildx on z for other open source project and seems to be working quite well. Regarding power, it's done by different team, probably won't PR both together, testing on platform could face different problem too.
There was a problem hiding this comment.
fair point -- I'm learning that vm and hardware access is a different challenge / schedule for each platform, with Z arriving before P, it seems.
|
Hi, this github action is like a PR check so it will just try to check if it can be build against another linux flavor but it will not publish the image So I think cico job needs to be removed and replaced by a "build-and-publish" Github Action |
|
@benoitf I believe this PR will update build-test-publish mechanism and present CI. Can you please guide on how we can approach to the required changes and what will be the action items on us/community ? |
shahidhs-ibm
force-pushed
the
s390x_multiarch_support
branch
from
7703178 to
73050e5
Compare
|
it may not be so useful as it's just for PR checks |
That's right. We have created another PR#307 which will enable multi-arch support to che-operator images. This PR is still in draft state as we are waiting for any progress on PR#109 which has similar changes and it is candidate for testing the multi-arch changes. |
|
Please rebase this PR. |
shahidhs-ibm
force-pushed
the
s390x_multiarch_support
branch
from
20acbee to
06f508e
Compare
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: benoitf, shahidhs-ibm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
shahidhs-ibm
force-pushed
the
s390x_multiarch_support
branch
2 times, most recently
from
8965864 to
1c65993
Compare
Signed-off-by: Shahid Shaikh <[email protected]>
shahidhs-ibm
force-pushed
the
s390x_multiarch_support
branch
from
60ecafb to
c47d94b
Compare
@nickboldt Done. Also made some changes in earlier PR'ed code to make use of Docker V2 GitHub Action. |
|
@nickboldt Any update? |
|
https://quay.io/repository/eclipse/che-operator?tag=latest&tab=tags |
|
eclipse-che/che#18809 |
Signed-off-by: Shahid Shaikh [email protected]
What does this PR do?
Add
docker buildxsupport to GitHub actions. Currently adding support for amd64 and s390x image build which can be expanded later to other architectures and multi-arch images can be pushed toquay.ioregistry.What issues does this PR fix or reference?
This PR is part of this initiative.