fix: Check identity providers for oauth instead of check amount users. #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrienkoAleksandr
requested review from
davidfestal,
l0rd,
nickboldt,
rhopp,
tolusha and
vparfonov
as code owners
56 tasks
tolusha
reviewed
May 12, 2020
tolusha
reviewed
May 12, 2020
tolusha
approved these changes
May 12, 2020
tolusha
reviewed
May 14, 2020
|
To fix olm tests it is needed to rebase on master |
AndrienkoAleksandr
force-pushed
the
checkIdentityProvidersForOAuth
branch
2 times, most recently
from
1d3b161 to
5fdc52a
Compare
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
AndrienkoAleksandr
force-pushed
the
checkIdentityProvidersForOAuth
branch
from
5fdc52a to
de99ef7
Compare
tolusha
approved these changes
May 14, 2020
Signed-off-by: Oleksandr Andriienko <[email protected]>
|
Tested with crc, openshift, minishift. |
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
|
Tested on OpenShift with and without oAuth Providers |
|
Tested with minishift. Works well and stable. Also tested moving from enabled oAuth to disabled and otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check identity providers for oauth instead of check amount users.
Referenced issue:
eclipse-che/che#16836