Make che-operator non blocking #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 30, 2020
tolusha
requested review from
davidfestal,
l0rd,
nickboldt,
rhopp and
vparfonov
as code owners
tolusha
changed the title
Signed-off-by: Anatoliy Bazko <[email protected]>
Signed-off-by: Anatoliy Bazko <[email protected]>
tolusha
changed the title
mmorhun
reviewed
Apr 7, 2020
mmorhun
reviewed
Apr 7, 2020
davidfestal
reviewed
Apr 9, 2020
Signed-off-by: Anatoliy Bazko <[email protected]>
Signed-off-by: Anatoliy Bazko <[email protected]>
Signed-off-by: Anatoliy Bazko <[email protected]>
davidfestal
reviewed
Apr 10, 2020
AndrienkoAleksandr
approved these changes
Apr 10, 2020
| ) | ||
|
|
||
| var ( | ||
| trustpass = util.GeneratePasswd(12) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
PR allows not to wait for minutes until deployment is ready and returns immediately into reconcile loop to process next events.
Commits to review
PR contains updates for vendor folder, so it is huge. Just review the following commits:
51fc885
Where did I test it?
How did I test it?
Observe che-operator logs to ensure deployment is non-blocking.
Reference issue
eclipse-che/che#15127