Skip to content

Commit

Permalink
Use 5m as a default startTimeout
Browse files Browse the repository at this point in the history
Signed-off-by: Anatolii Bazko <[email protected]>
  • Loading branch information
tolusha committed Dec 22, 2022
1 parent 9b02186 commit 59b4f81
Show file tree
Hide file tree
Showing 9 changed files with 27 additions and 18 deletions.
6 changes: 4 additions & 2 deletions api/v2/checluster_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ type CheClusterSpec struct {
// +optional
// +operator-sdk:csv:customresourcedefinitions:type=spec,order=1
// +operator-sdk:csv:customresourcedefinitions:type=spec,displayName="Development environments"
// +kubebuilder:default:={disableContainerBuildCapabilities: true, defaultComponents: {{name: universal-developer-image, container: {image: "quay.io/devfile/universal-developer-image:ubi8-38da5c2"}}}, defaultEditor: che-incubator/che-code/insiders, storage: {pvcStrategy: per-user}, defaultNamespace: {template: <username>-che, autoProvision: true}, secondsOfInactivityBeforeIdling:1800, secondsOfRunBeforeIdling:-1}
// +kubebuilder:default:={disableContainerBuildCapabilities: true, defaultComponents: {{name: universal-developer-image, container: {image: "quay.io/devfile/universal-developer-image:ubi8-38da5c2"}}}, defaultEditor: che-incubator/che-code/insiders, storage: {pvcStrategy: per-user}, defaultNamespace: {template: <username>-che, autoProvision: true}, secondsOfInactivityBeforeIdling:1800, secondsOfRunBeforeIdling:-1, startTimeout:"5m"}
DevEnvironments CheClusterDevEnvironments `json:"devEnvironments"`
// Che components configuration.
// +optional
Expand Down Expand Up @@ -126,7 +126,9 @@ type CheClusterDevEnvironments struct {
// StartTimeout determines the maximum duration a workspace can take to start
// before it is automatically failed.
// Duration should be specified in a format parseable by Go's time package, e.g.
// "15m", "20s", "1h30m", etc. If not specified, the default value of "5m" is used.
// "15m", "20s", "1h30m", etc.
// +optional
// +kubebuilder:default:="5m"
StartTimeout string `json:"startTimeout,omitempty"`
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ metadata:
operators.operatorframework.io/project_layout: go.kubebuilder.io/v3
repository: https://github.com/eclipse-che/che-operator
support: Eclipse Foundation
name: eclipse-che.v7.59.0-741.next
name: eclipse-che.v7.59.0-742.next
namespace: placeholder
spec:
apiservicedefinitions: {}
Expand Down Expand Up @@ -1233,7 +1233,7 @@ spec:
minKubeVersion: 1.19.0
provider:
name: Eclipse Foundation
version: 7.59.0-741.next
version: 7.59.0-742.next
webhookdefinitions:
- admissionReviewVersions:
- v1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5410,6 +5410,7 @@ spec:
disableContainerBuildCapabilities: true
secondsOfInactivityBeforeIdling: 1800
secondsOfRunBeforeIdling: -1
startTimeout: 5m
storage:
pvcStrategy: per-user
description: Development environment default configuration options.
Expand Down Expand Up @@ -7006,11 +7007,11 @@ spec:
pattern: ^[a-z0-9]([-a-z0-9]*[a-z0-9])?$
type: string
startTimeout:
default: 5m
description: StartTimeout determines the maximum duration a
workspace can take to start before it is automatically failed.
Duration should be specified in a format parseable by Go's
time package, e.g. "15m", "20s", "1h30m", etc. If not specified,
the default value of "5m" is used.
time package, e.g. "15m", "20s", "1h30m", etc.
type: string
storage:
default:
Expand Down
5 changes: 3 additions & 2 deletions config/crd/bases/org.eclipse.che_checlusters.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5271,6 +5271,7 @@ spec:
disableContainerBuildCapabilities: true
secondsOfInactivityBeforeIdling: 1800
secondsOfRunBeforeIdling: -1
startTimeout: 5m
storage:
pvcStrategy: per-user
description: Development environment default configuration options.
Expand Down Expand Up @@ -6816,11 +6817,11 @@ spec:
pattern: ^[a-z0-9]([-a-z0-9]*[a-z0-9])?$
type: string
startTimeout:
default: 5m
description: StartTimeout determines the maximum duration a workspace
can take to start before it is automatically failed. Duration
should be specified in a format parseable by Go's time package,
e.g. "15m", "20s", "1h30m", etc. If not specified, the default
value of "5m" is used.
e.g. "15m", "20s", "1h30m", etc.
type: string
storage:
default:
Expand Down
5 changes: 3 additions & 2 deletions deploy/deployment/kubernetes/combined.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5290,6 +5290,7 @@ spec:
disableContainerBuildCapabilities: true
secondsOfInactivityBeforeIdling: 1800
secondsOfRunBeforeIdling: -1
startTimeout: 5m
storage:
pvcStrategy: per-user
description: Development environment default configuration options.
Expand Down Expand Up @@ -6835,11 +6836,11 @@ spec:
pattern: ^[a-z0-9]([-a-z0-9]*[a-z0-9])?$
type: string
startTimeout:
default: 5m
description: StartTimeout determines the maximum duration a workspace
can take to start before it is automatically failed. Duration
should be specified in a format parseable by Go's time package,
e.g. "15m", "20s", "1h30m", etc. If not specified, the default
value of "5m" is used.
e.g. "15m", "20s", "1h30m", etc.
type: string
storage:
default:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5285,6 +5285,7 @@ spec:
disableContainerBuildCapabilities: true
secondsOfInactivityBeforeIdling: 1800
secondsOfRunBeforeIdling: -1
startTimeout: 5m
storage:
pvcStrategy: per-user
description: Development environment default configuration options.
Expand Down Expand Up @@ -6830,11 +6831,11 @@ spec:
pattern: ^[a-z0-9]([-a-z0-9]*[a-z0-9])?$
type: string
startTimeout:
default: 5m
description: StartTimeout determines the maximum duration a workspace
can take to start before it is automatically failed. Duration
should be specified in a format parseable by Go's time package,
e.g. "15m", "20s", "1h30m", etc. If not specified, the default
value of "5m" is used.
e.g. "15m", "20s", "1h30m", etc.
type: string
storage:
default:
Expand Down
5 changes: 3 additions & 2 deletions deploy/deployment/openshift/combined.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5290,6 +5290,7 @@ spec:
disableContainerBuildCapabilities: true
secondsOfInactivityBeforeIdling: 1800
secondsOfRunBeforeIdling: -1
startTimeout: 5m
storage:
pvcStrategy: per-user
description: Development environment default configuration options.
Expand Down Expand Up @@ -6835,11 +6836,11 @@ spec:
pattern: ^[a-z0-9]([-a-z0-9]*[a-z0-9])?$
type: string
startTimeout:
default: 5m
description: StartTimeout determines the maximum duration a workspace
can take to start before it is automatically failed. Duration
should be specified in a format parseable by Go's time package,
e.g. "15m", "20s", "1h30m", etc. If not specified, the default
value of "5m" is used.
e.g. "15m", "20s", "1h30m", etc.
type: string
storage:
default:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5285,6 +5285,7 @@ spec:
disableContainerBuildCapabilities: true
secondsOfInactivityBeforeIdling: 1800
secondsOfRunBeforeIdling: -1
startTimeout: 5m
storage:
pvcStrategy: per-user
description: Development environment default configuration options.
Expand Down Expand Up @@ -6830,11 +6831,11 @@ spec:
pattern: ^[a-z0-9]([-a-z0-9]*[a-z0-9])?$
type: string
startTimeout:
default: 5m
description: StartTimeout determines the maximum duration a workspace
can take to start before it is automatically failed. Duration
should be specified in a format parseable by Go's time package,
e.g. "15m", "20s", "1h30m", etc. If not specified, the default
value of "5m" is used.
e.g. "15m", "20s", "1h30m", etc.
type: string
storage:
default:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5285,6 +5285,7 @@ spec:
disableContainerBuildCapabilities: true
secondsOfInactivityBeforeIdling: 1800
secondsOfRunBeforeIdling: -1
startTimeout: 5m
storage:
pvcStrategy: per-user
description: Development environment default configuration options.
Expand Down Expand Up @@ -6830,11 +6831,11 @@ spec:
pattern: ^[a-z0-9]([-a-z0-9]*[a-z0-9])?$
type: string
startTimeout:
default: 5m
description: StartTimeout determines the maximum duration a workspace
can take to start before it is automatically failed. Duration
should be specified in a format parseable by Go's time package,
e.g. "15m", "20s", "1h30m", etc. If not specified, the default
value of "5m" is used.
e.g. "15m", "20s", "1h30m", etc.
type: string
storage:
default:
Expand Down

0 comments on commit 59b4f81

Please sign in to comment.