-
Notifications
You must be signed in to change notification settings - Fork 25
Github action with multi-CPU architecture support and multi docker file support #30
Conversation
It is leaving rhel.Dockerfile untouched is it still working ? |
should all cico scripts be disabled/removed as well ? it won't collide ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Vendoring was evil anyway :)
Yes, I've checked. It works.
Don't want to hurry up. Let's live it for some time.
Don't know. Need to talk with @mkuznyetsov @nickboldt |
@skabashnyuk +0. I'm not going to comment on a PR that changes 417 files in a repo for which I'm neither an owner not an expert. If you want my input please make this into a set of several smaller, more manageable PRs. That said... I don't see any changes to a rhel.Dockerfile similar to what you changed in Dockerfile, so this change might not be reflected in downstream. Is that intentional? |
@nickboldt it has 5 changed files and removed vendor folder are you sure you want me to split it? |
No, I'm OK with the deleted files since you explained the rationale in Slack. Upgrading my vote to +0.5 But I'm still wondering if you've forgotten to do anything in the rhel.Dockerfile file to match your changes in Dockerfile. If you can explain why these changes are not applicable to downstream (as I suspect is the case), or add changes to the rhel.Dockerfile too, then I'll be +1. |
The core and the significant part I believe are identical. |
Results https://quay.io/repository/skabashn/che-jwtproxy?tab=tags
Synced code with che-incubator/configbump#5