Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview URL documentation #839

Merged
merged 2 commits into from
Oct 24, 2019
Merged

Preview URL documentation #839

merged 2 commits into from
Oct 24, 2019

Conversation

sparkoo
Copy link
Member

@sparkoo sparkoo commented Oct 8, 2019

Signed-off-by: Michal Vala [email protected]

What does this PR do?

documents Command's previewurl

What issues does this PR fix or reference?

eclipse-che/che#14713 (PR eclipse-che/che#14713)

Copy link

@rkratky rkratky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @sparkoo. Some changes suggested.

@sparkoo sparkoo changed the title devfile>command>previewurl doc 🚧 devfile>command>previewurl doc Oct 17, 2019
Co-Authored-By: Robert Krátký <[email protected]>
Signed-off-by: Michal Vala <[email protected]>
@sparkoo sparkoo changed the title 🚧 devfile>command>previewurl doc devfile>command>previewurl doc Oct 17, 2019
@sparkoo sparkoo requested a review from rkratky October 17, 2019 23:06
@sparkoo sparkoo changed the title devfile>command>previewurl doc Preview URL documentation Oct 17, 2019
Signed-off-by: Michal Vala <[email protected]>
@sparkoo sparkoo merged commit 9a989f2 into eclipse-che:master Oct 24, 2019
@sparkoo sparkoo deleted the previewurl branch October 24, 2019 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants