fix: splitting the Collecting Dev Workspace Operator metrics procedure into upstream and downstream versions #2599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Click here to review and test in web IDE: |
-525C86?logo=eclipse-che&labelColor=red){kind=icon}
|
🎊 Navigate the preview: https://646246bd88be352ba758eab4--eclipse-che-docs-pr.netlify.app 🎊 |
dkwon17
approved these changes
May 15, 2023
...on-guide/examples/snip_che-create-a-role-and-rolebinding-for-prometheus-to-view-metrics.adoc
Show resolved
Hide resolved
6 tasks
max-cx
added a commit
that referenced
this pull request
May 15, 2023
…e into upstream and downstream versions (#2599) * typo (#2582) * Revert "typo (#2582)" This reverts commit 01a4cb0. * fix: replicating changes from PR 2595 due to a committer's signature issue --------- Co-authored-by: Jose Manuel <[email protected]>
max-cx
added a commit
that referenced
this pull request
May 15, 2023
…e into upstream and downstream versions (#2599) * typo (#2582) * Revert "typo (#2582)" This reverts commit 01a4cb0. * fix: replicating changes from PR 2595 due to a committer's signature issue --------- Co-authored-by: Jose Manuel <[email protected]>
max-cx
added a commit
that referenced
this pull request
May 15, 2023
…e into upstream and downstream versions (#2599) * typo (#2582) * Revert "typo (#2582)" This reverts commit 01a4cb0. * fix: replicating changes from PR 2595 due to a committer's signature issue --------- Co-authored-by: Jose Manuel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request change?
This PR clones #2595, which had an issue with https://accounts.eclipse.org/user/login?destination=legal/eca/validation/152502.
Step 2 of the procedure is kept in the Che docs but removed from the Dev Spaces docs:
https://www.eclipse.org/che/docs/stable/administration-guide/monitoring-the-dev-workspace-operator/#proc_collecting-dev-workspace-operator-metrics-with-prometheus
What issues does this pull request fix or reference?
This is a follow-up to #2586 as requested by @dkwon17
Specify the version of the product this pull request applies to
Merge to
mainCherry-pick to
7.62.x,7.63.x, and7.64.xPull Request checklist
The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.
Validate language on files added or modifiedstep reports no vale warnings.