Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove PostgreSQL component #2561

Merged
merged 1 commit into from
Mar 2, 2023
Merged

feat: Remove PostgreSQL component #2561

merged 1 commit into from
Mar 2, 2023

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Feb 23, 2023

What does this pull request change?

feat: Remove PostgreSQL component

What issues does this pull request fix or reference?

eclipse-che/che#21374

Specify the version of the product this pull request applies to

7.62.0

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@tolusha tolusha marked this pull request as ready for review February 23, 2023 11:04
@tolusha tolusha requested review from rkratky, max-cx, deerskindoll and a team as code owners February 23, 2023 11:04
@tolusha tolusha requested a review from ibuziuk February 23, 2023 11:04
@github-actions
Copy link

github-actions bot commented Feb 23, 2023

🎊 Navigate the preview: https://6400d890825f5600826bffa9--eclipse-che-docs-pr.netlify.app 🎊

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tolusha I remember we also had a doc related to external db setup. Not sure if it still exists but would be great to also clean it up

Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this page was cleaned (including images) - https://www.eclipse.org/che/docs/stable/administration-guide/postgresql/

@tolusha
Copy link
Contributor Author

tolusha commented Feb 27, 2023

@ibuziuk
I've just removed by patching https://github.com/eclipse-che/che-docs/pull/2561/files#diff-85f5122b45d94b158231e52496a9d105a9c751328415936189408f9b966ac298

I can't find any docs with regard to external db setup.

@max-cx max-cx self-assigned this Mar 2, 2023
@max-cx max-cx removed their assignment Mar 2, 2023
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two mini suggestions

@ibuziuk
Copy link
Member

ibuziuk commented Mar 2, 2023

@deerskindoll thank you for the review, suggestions have been applied 👍

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@deerskindoll deerskindoll merged commit 5d4c62c into main Mar 2, 2023
@deerskindoll deerskindoll deleted the 21374 branch March 2, 2023 17:36
@che-bot che-bot added this to the 7.62 milestone Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants