Setting up Keycloak che-username-readonly-theme #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatolii Bazko <[email protected]>
tolusha
requested review from
yhontyk,
MichalMaler,
rkratky,
themr0c and
a team
as code owners
56 tasks
|
Hello Anatolii. Nice work. Do you think you could send me the equivalent of those screenshots from CRW? Since there is the CHE branding, it will appear in the CRW docs after downstream. I will fix that but need those crw screenshots. |
|
It is committed in the PR |
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
MichalMaler
added
kind/docs
kind/enhancement
need-cherry-pick/7.32.x
|
Good job with those screenshots. Let me check it now. |
MichalMaler
approved these changes
Dec 9, 2020
MichalMaler
changed the title
MichalMaler
reviewed
Dec 9, 2020
Signed-off-by: Michal Maléř <[email protected]>
Co-authored-by: Robert Krátký <[email protected]>
Signed-off-by: Michal Maléř <[email protected]>
Signed-off-by: Michal Maléř <[email protected]>
Signed-off-by: Michal Maléř <[email protected]>
MichalMaler
changed the title
MichalMaler
approved these changes
Dec 10, 2020
yhontyk
pushed a commit
that referenced
this pull request
Dec 11, 2020
* Setting up Keycloak che-username-readonly-theme Signed-off-by: Anatolii Bazko <[email protected]> * Fixes Signed-off-by: Anatolii Bazko <[email protected]> * Fixes Signed-off-by: Anatolii Bazko <[email protected]> * Minor changes Signed-off-by: Michal Maléř <[email protected]> * Apply suggestions from code review Co-authored-by: Robert Krátký <[email protected]> * renaming file to make the match Signed-off-by: Michal Maléř <[email protected]> * Edits Signed-off-by: Michal Maléř <[email protected]> * removing unused attribute Signed-off-by: Michal Maléř <[email protected]> Co-authored-by: Michal Maléř <[email protected]> Co-authored-by: Michal Maléř <[email protected]> Co-authored-by: Robert Krátký <[email protected]>
yhontyk
added
cherry-picked to 7.32.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anatolii Bazko [email protected]
What does this PR do?
Add section to set up Keycloak che-username-readonly-theme
What issues does this PR fix or reference?
https://issues.redhat.com/browse/RHDEVDOCS-2453
PR Checklist
As the author of this Pull Request I made sure that:
valehas been run successfully against the PR branch