Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching between external and internal ways in inter-component communication #1704

Merged
merged 4 commits into from
Dec 1, 2020

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Nov 27, 2020

Signed-off-by: Anatolii Bazko [email protected]

Read our Contribution guide before submitting a PR.

What does this PR do?

Add section Switching between external and internal ways in inter-component communication

What issues does this PR fix or reference?

eclipse-che/che#17644

PR Checklist

As the author of this Pull Request I made sure that:

  • vale has been run successfully against the PR branch
  • Link checker has been run successfully against the PR branch
  • Documentation describes a scenario that is already covered by QE tests, otherwise an issue has been created and acknowledged by Che QE team
  • Changed article references are updated where they are used (or a redirect has been set up on the docs side):

screenshot-0 0 0 0_4000-2020 11 27-13_31_03

@tolusha
Copy link
Contributor Author

tolusha commented Nov 30, 2020

@themr0c
Could you review pls?

@themr0c themr0c self-assigned this Nov 30, 2020
Copy link
Contributor

@themr0c themr0c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, please find some minor suggestions.

tolusha and others added 3 commits November 30, 2020 16:29
…ernal-and-internal-communication.adoc

Co-authored-by: Fabrice Flore-Thébault <[email protected]>
…ernal-and-internal-communication.adoc

Co-authored-by: Fabrice Flore-Thébault <[email protected]>
…ernal-and-internal-communication.adoc

Co-authored-by: Fabrice Flore-Thébault <[email protected]>
@tolusha
Copy link
Contributor Author

tolusha commented Dec 1, 2020

Can I merge this?

@MichalMaler MichalMaler merged commit 5b3c345 into eclipse-che:master Dec 1, 2020
@MichalMaler MichalMaler added need-cherry-pick/7.32.x need cherry-pick to 7.32.x and removed need-cherry-pick/7.32.x need cherry-pick to 7.32.x labels Dec 1, 2020
@MichalMaler
Copy link
Contributor

This content is CRW 2.7 I just removed that 7.20.x tag, it was a misclick.

@themr0c
Copy link
Contributor

themr0c commented Dec 1, 2020

I assume it works with current released Che so it's fine to merge.

@themr0c themr0c added this to the 7.21 milestone Dec 1, 2020
@tolusha
Copy link
Contributor Author

tolusha commented Dec 1, 2020

Sorry, my mistake for CRW 2.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants